From: sashiko-bot@kernel.org
To: "Kameron Carr" <kameroncarr@linux.microsoft.com>
Cc: linux-hyperv@vger.kernel.org
Subject: Re: [PATCH v4 1/6] arm64: rsi: Add RSI host call structure and helper function
Date: Fri, 02 Oct 2026 09:13:53 +0000 [thread overview]
Message-ID: <20261002091353.F41471F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261001220552.1793471-2-kameroncarr@linux.microsoft.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] docs: commit message incorrectly names modified headers
--
commit 12e4ec5d9cab90f44760cb6771af64451e5a4884
Author: Kameron Carr <kameroncarr@linux.microsoft.com>
arm64: rsi: Add RSI host call structure and helper function
This commit adds the rsi_host_call data structure and an rsi_host_call()
wrapper function for routing hypercalls through the RSI interface.
> Add struct rsi_host_call to rsi_smc.h, which represents the host call
> data structure used by the Realm Management Monitor (RMM) for the
> RSI_HOST_CALL interface. The structure contains a 16-bit immediate field
> and 31 general-purpose register values, aligned to 256 bytes as required
> by the CCA RMM specification.
>
> Add rsi_host_call() static inline wrapper in rsi_cmds.h that invokes
[Severity: Low]
This isn't a bug, but the commit message states the structure and wrapper are
added to rsi_smc.h and rsi_cmds.h. The patch actually modifies
include/linux/arm-smccc-rsi.h and include/linux/arm-rsi-cmds.h instead.
Could the commit message be updated to reflect the actual header names being
modified?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261001220552.1793471-1-kameroncarr@linux.microsoft.com?part=1
next prev parent reply other threads:[~2026-10-02 9:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 22:05 [PATCH v4 0/6] arm64: hyperv: Add Realm support for Hyper-V Kameron Carr
2026-10-01 22:05 ` [PATCH v4 1/6] arm64: rsi: Add RSI host call structure and helper function Kameron Carr
2026-10-02 9:13 ` sashiko-bot [this message]
2026-10-01 22:05 ` [PATCH v4 2/6] firmware: smccc: Detect hypervisor via RSI host call in CCA Realms Kameron Carr
2026-10-02 9:13 ` sashiko-bot
2026-10-01 22:05 ` [PATCH v4 3/6] arm64: hyperv: Add per-CPU RSI host call infrastructure for " Kameron Carr
2026-10-02 9:13 ` sashiko-bot
2026-10-01 22:05 ` [PATCH v4 4/6] Drivers: hv: Mark shared memory as decrypted " Kameron Carr
2026-10-01 22:05 ` [PATCH v4 5/6] arm64: hyperv: Route hypercalls through RSI host call in " Kameron Carr
2026-10-02 9:13 ` sashiko-bot
2026-10-01 22:05 ` [PATCH v4 6/6] arm64: hyperv: Implement hv_is_isolation_supported() for " Kameron Carr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002091353.F41471F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=kameroncarr@linux.microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.