Re: [PATCH v3 1/7] dt-bindings: power: qcom-rpmpd: define RPMPD_VDDMD

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] dt-bindings: RPMPD_VDDMD incorrectly shares index 5 with RPMPD_VDDMX_VFL
--

commit 12f0f9a3ab8aa298b418ea38da861f57dfeb42fb
Author: Barnabás Czémán <barnabas.czeman@mainlining.org>

dt-bindings: power: qcom-rpmpd: define RPMPD_VDDMD

This commit adds a new generic power domain index, RPMPD_VDDMD, intended
for use with SDM439 and SDM632 MSS.

> diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
> index 4371ac941f29d..beb066b3aa8c6 100644
> --- a/include/dt-bindings/power/qcom-rpmpd.h
> +++ b/include/dt-bindings/power/qcom-rpmpd.h
> @@ -15,6 +15,7 @@
>  #define RPMPD_VDDMX		3
>  #define RPMPD_VDDMX_AO		4
>  #define RPMPD_VDDMX_VFL		5
> +#define RPMPD_VDDMD		5

[Severity: High]
Will this duplicate index cause a conflict for platforms that require both
the Modem Power Domain (RPMPD_VDDMD) and the Memory Voltage Floor Domain
(RPMPD_VDDMX_VFL)?

These values map directly to designated array initializers in the provider
driver (drivers/pmdomain/qcom/rpmpd.c). If a platform descriptor array
includes both, the duplicate index 5 could cause the compiler to silently
overwrite one of the array elements, rendering that domain unusable at
runtime.

Would it be possible to assign a globally unique ID (such as the next
available index) to prevent overlap?

>  #define RPMPD_SSCCX		6
>  #define RPMPD_SSCCX_VFL		7
>  #define RPMPD_SSCMX		8

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261002-sdm632-rpmpd-v3-0-95c47d0f26cf@mainlining.org?part=1