Re: [PATCH] perf stat: Fix aggregation of cgroup events

[sashiko-bot@kernel.org]

> I got a report that perf stat with BPF and cgroup is broken with
> aggregation like per-socket or node.  On my machine, running the
> following command shows the problem.
> 
>   $ sudo perf stat -a --bpf-counters --per-socket -e cycles \
>     --for-each-cgroup /user.slice,/system.slice  sleep 1
> 
>    Performance counter stats for 'system wide':
> 
>   S0       12      <not counted>      cpu_atom/cycles/                 user.slice
>   S0       16      <not counted>      cpu_core/cycles/                 user.slice
>   S0       12      <not counted>      cpu_atom/cycles/                 system.slice
>   S0       16      <not counted>      cpu_core/cycles/                 system.slice
> 
>          1.002798147 seconds time elapsed
> [ ... ]
> 
>          1.003231856 seconds time elapsed
> 
> Reported-by: Chun-Tse Shao <ctshao@google.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261002054832.64980-1-namhyung@kernel.org?part=1