Re: [PATCH v3 1/3] dt-bindings: mfd: as3722: Convert to json-schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dt-bindings: as3722: regex pattern for pinmux nodes rejects existing hyphens
- [Low] dt-bindings: as3722: ams,enable-tracking missing restriction to ldo3
--

commit d71712428dc3759a032b4331de89438e39e0ee5b
Author: Thierry Reding <treding@nvidia.com>

dt-bindings: mfd: as3722: Convert to json-schema
    
Convert the AMS AS3722 PMIC bindings from the free-form text format to
json-schema.

> diff --git a/Documentation/devicetree/bindings/mfd/ams,as3722.yaml b/Documentation/devicetree/bindings/mfd/ams,as3722.yaml
> new file mode 100644
> index 0000000000000..51910042c6216
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ams,as3722.yaml

[ ... ]

> @@ -0,0 +1,293 @@

[ ... ]

> +  pinmux:
> +    description:
> +      Device has 8 GPIO pins which can be configured as GPIO as well as the
> +      special IO functions.
> +
> +    type: object
> +    additionalProperties: false
> +
> +    patternProperties:
> +      "^gpio[0-7_]+$":

[Severity: Medium]
Will this strict regex exclude the hyphen character and cause validation to
fail for existing in-tree device trees?

Existing device trees like arch/arm/boot/dts/nvidia/tegra124-apalis.dtsi use
hyphens in their node names, such as gpio0-1-3-4-5-6. Because these valid
names contain hyphens, do they fail to match the pattern, fall through to
additionalProperties: false, and trigger a schema violation error?

[ ... ]

> +    patternProperties:
> +      "^(sd[0-6]|ldo[0-7]|ldo9|ldo10|ldo11)$":
> +        description:
> +          These sub-nodes must be named after one of the regulators found on
> +          the AS3277. Each sub-node should contain the constraints and
> +          initialization information for that regulator.
> +
> +        $ref: /schemas/regulator/regulator.yaml#
> +        unevaluatedProperties: false
> +        type: object
> +
> +        properties:

[ ... ]

> +          ams,enable-tracking:
> +            description: Enable tracking with SD1, only supported by LDO3.
> +
> +            $ref: /schemas/types.yaml#/definitions/flag

[Severity: Low]
Is the ams,enable-tracking property missing a restriction to ldo3?

The text description explicitly states it is only supported by LDO3, but it
appears to be allowed for all regulators matching the parent pattern. Without
an allOf/if-then constraint to restrict its application strictly to the ldo3
node, users could mistakenly apply ams,enable-tracking to unsupported
regulators.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261002-as3722-bindings-v3-0-21c179b72a95@nvidia.com?part=1