From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH v2 03/20] trace: fix handling of char** in UST backend
Date: Fri, 2 Oct 2026 10:52:15 +0100 [thread overview]
Message-ID: <20261002095232.3605567-4-berrange@redhat.com> (raw)
In-Reply-To: <20261002095232.3605567-1-berrange@redhat.com>
The UST trace backend fails to compile on version 2.14.0, as we
pass a "char **" arg as to ctf_string(), which only expects 'char *'.
It should instead be treated the same way as generic pointers, and
emitted as hex.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
scripts/tracetool/format/ust_events_h.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/tracetool/format/ust_events_h.py b/scripts/tracetool/format/ust_events_h.py
index cee7970a403..76c883bc5c0 100644
--- a/scripts/tracetool/format/ust_events_h.py
+++ b/scripts/tracetool/format/ust_events_h.py
@@ -72,7 +72,9 @@ def generate(events, backend, group):
names = e.args.names()
fmts = e.formats()
for t,n,f in zip(types, names, fmts):
- if ('char *' in t) or ('char*' in t):
+ if ('char **' in t) or ('char**' in t):
+ out(' ctf_integer_hex(' + t + ', ' + n + ', ' + n + ')')
+ elif ('char *' in t) or ('char*' in t):
out(' ctf_string(' + n + ', ' + n + ')')
elif ("%p" in f) or ("x" in f) or ("PRIx" in f):
out(' ctf_integer_hex('+ t + ', ' + n + ', ' + n + ')')
--
2.55.0
next prev parent reply other threads:[~2026-10-02 9:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 9:52 [PATCH v2 00/20] trace: bugfixes, cleanups and optimizations Daniel P. Berrangé
2026-10-02 9:52 ` [PATCH v2 01/20] osdep: add 'ignore_value(x)' macro Daniel P. Berrangé
2026-10-02 10:39 ` Markus Armbruster
2026-10-02 9:52 ` [PATCH v2 02/20] trace: use 'ignore_value()' instead of a dummy variable Daniel P. Berrangé
2026-10-02 9:52 ` Daniel P. Berrangé [this message]
2026-10-02 9:52 ` [PATCH v2 04/20] hw/xen: replace "long unsigned int" with "unsigned long " for dtrace Daniel P. Berrangé
2026-10-02 9:52 ` [PATCH v2 05/20] trace: block use of "long int" " Daniel P. Berrangé
2026-10-02 9:52 ` [PATCH v2 06/20] trace: drop unused trace_event_set_state_dynamic_init() Daniel P. Berrangé
2026-10-02 9:52 ` [PATCH v2 07/20] trace: remove obsolete references to vcpu property Daniel P. Berrangé
2026-10-02 9:52 ` [PATCH v2 08/20] trace: drop 'id' from TraceEvent struct when not required Daniel P. Berrangé
2026-10-02 9:52 ` [PATCH v2 09/20] trace: change "DSTATE" variables from uint16_t to uint8_t Daniel P. Berrangé
2026-10-02 9:52 ` [PATCH v2 10/20] trace: add testing of 'nop' trace backend Daniel P. Berrangé
2026-10-02 9:52 ` [PATCH v2 11/20] trace: don't emit TraceEvent structs when 'nop' backend is used Daniel P. Berrangé
2026-10-02 9:52 ` [PATCH v2 12/20] trace: add test of generation with all backends enabled Daniel P. Berrangé
2026-10-02 9:52 ` [PATCH v2 13/20] trace: remove redundant headers from simple trace backend code Daniel P. Berrangé
2026-10-02 9:52 ` [PATCH v2 14/20] audio: remove mistaken use of trace_event_get_state() Daniel P. Berrangé
2026-10-02 9:52 ` [PATCH v2 15/20] hw/ppc: " Daniel P. Berrangé
2026-10-02 9:52 ` [PATCH v2 16/20] trace: include qemu_loglevel_mask(LOG_TRACE) in guard Daniel P. Berrangé
2026-10-02 9:52 ` [PATCH v2 17/20] trace: remove "disable" property from trace files Daniel P. Berrangé
2026-10-02 9:52 ` [PATCH v2 18/20] trace: stop tracking static disabled state Daniel P. Berrangé
2026-10-02 9:52 ` [PATCH v2 19/20] trace: remove parsing of "disable" event property Daniel P. Berrangé
2026-10-02 9:52 ` [PATCH v2 20/20] trace: remove 'trace_event_get_state' wrapper Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002095232.3605567-4-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.