Re: [PATCH 4/5] ASoC: pcm179x: Add pcm1796 as compatible with pcm1792a

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] spi: missing pcm1796 spi_device_id breaks module autoloading
--

commit 8959b1de4bb8c22b7a8a0f59806c5a6f767c0c82
Author: Roman Smrž <roman@amarulasolutions.com>

ASoC: pcm179x: Add pcm1796 as compatible with pcm1792a

The PCM1796 is fully compatible with the PCM1792A.

> diff --git a/sound/soc/codecs/pcm179x-spi.c b/sound/soc/codecs/pcm179x-spi.c
> index 192fee90c9714..e5e4b942acfc5 100644
> --- a/sound/soc/codecs/pcm179x-spi.c
> +++ b/sound/soc/codecs/pcm179x-spi.c
> @@ -31,6 +31,7 @@ static int pcm179x_spi_probe(struct spi_device *spi)
>  
>  static const struct of_device_id pcm179x_of_match[] __maybe_unused = {
>  	{ .compatible = "ti,pcm1792a", },
> +	{ .compatible = "ti,pcm1796" },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(of, pcm179x_of_match);

[Severity: High]
Should pcm179x_spi_ids[] also include an entry for "pcm1796"?

Without a "pcm1796" entry in pcm179x_spi_ids[], SPI module autoloading fails
for DT-instantiated devices and legacy board-file matching fails.

The SPI core (__spi_register_driver()) explicitly enforces OF-to-SPI ID
parity and will emit a warning during driver registration.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261002-work-v1-0-f0e53bc7331f@amarulasolutions.com?part=4