Re: [PATCH v5 3/9] PCI: rzg3s-host: Select PCI_HOST_COMMON

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Kconfig: unnecessary selection of PCI_HOST_COMMON causes kernel bloat
--

commit 45902cd2b000fac7ca52cf6e5a8c266554c39e27
Author: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

PCI: rzg3s-host: Select PCI_HOST_COMMON

This commit adds a select for PCI_HOST_COMMON to the PCIE_RENESAS_RZG3S_HOST
kconfig option. It states this is needed for pci_host_common_link_train_delay()
to avoid build failures.

> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index d246bbe37948e..3e2889a7f1a09 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -296,6 +296,7 @@ config PCIE_RENESAS_RZG3S_HOST
>  	depends on ARCH_RENESAS || COMPILE_TEST
>  	select MFD_SYSCON
>  	select IRQ_MSI_LIB
> +	select PCI_HOST_COMMON

[Severity: Medium]
Is this select actually required for the build?

The commit message notes that pci_host_common_link_train_delay() depends on
PCI_HOST_COMMON. However, looking at the header,
pci_host_common_link_train_delay() is implemented as a static inline function
entirely within pci-host-common.h and only requires linux/delay.h. There
doesn't appear to be any link dependency on pci-host-common.c.

Since selecting a tristate from a bool config forces PCI_HOST_COMMON and
PCI_ECAM to be built-in rather than modules, could this be pulling in
unneeded infrastructure and unnecessarily increasing the vmlinux size?

>  	help
>  	  Say Y here if you want PCIe host controller support on Renesas RZ/G3S
>  	  SoC.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261002110935.2004349-1-claudiu.beznea@kernel.org?part=3