From: sashiko-bot@kernel.org
To: "James Clark" <james.clark@linaro.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v3 2/4] perf cs-etm: Free partially created queues
Date: Fri, 02 Oct 2026 11:27:01 +0000 [thread overview]
Message-ID: <20261002112702.3EE9E1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261002-james-cs-hw_id-output-failure-v3-2-1d8b6ef339c8@linaro.org>
> cs_etm__create_decoders() can fail half way through and the
> err_free_queues label won't free them. Call the full queue free function
> here instead. If no decoders were created it's a nop.
>
> Reviewed-by: Leo Yan <leo.yan@arm.com>
> Signed-off-by: James Clark <james.clark@linaro.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261002-james-cs-hw_id-output-failure-v3-0-1d8b6ef339c8@linaro.org?part=2
next prev parent reply other threads:[~2026-10-02 11:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 11:15 [PATCH v3 0/4] perf: cs-etm: HW_ID improvements James Clark
2026-10-02 11:15 ` [PATCH v3 1/4] perf: cs-etm: Don't add global v0 HW_IDs to unformatted queues James Clark
2026-10-02 11:28 ` sashiko-bot
2026-10-02 16:02 ` Leo Yan
2026-10-02 11:15 ` [PATCH v3 2/4] perf cs-etm: Free partially created queues James Clark
2026-10-02 11:27 ` sashiko-bot [this message]
2026-10-02 11:15 ` [PATCH v3 3/4] perf cs-etm: Synthesize missing HW_ID mappings for raw trace James Clark
2026-10-02 11:23 ` sashiko-bot
2026-10-02 17:14 ` Leo Yan
2026-10-05 8:33 ` James Clark
2026-10-02 11:15 ` [PATCH v3 4/4] perf: cs-etm: Respect --no-itrace option James Clark
2026-10-02 11:26 ` sashiko-bot
2026-10-02 17:22 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002112702.3EE9E1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=james.clark@linaro.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.