Re: [PATCH v2 4/7] PCI: Fix nesting windows with remainder at the left edge

[sashiko-bot@kernel.org]

> If a bridge window has its non-aligning remainder at the left edge of
> the window, assigning a nested bridge window of same size will fail
> because resource side code will only allow starting a candicate range
> from an aligning address. In such case, aligned address is somewhere in
> the middle, not at the left edge of the window. Since the entire
> available space is required for full-sized nested bridge window,
> resource side code rejects the free space.
> 
> To solve this problem, PCI side code has to bypass the resource side
> alignment code by giving a smaller alignment and must check the
> aligment requirement itself. This allows resource side code to consider
> the entire available space as candidate to fit the required size.
> 
> Wrap pcibios_align_resource() with PCI core function that performs the
> alignment checks and left edge recalculation if needed. As the
> alignment given for the resource side code is artificially small, the
> real alignment has to be passed through alignf_data.
> 
> Fixes: 9036bd0efcb6 ("PCI: Align head space better")
> Tested-by: Nikolas Joshua Britton <nbritton@exabit.io>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261002113319.6652-1-ilpo.jarvinen@linux.intel.com?part=4