All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: Linus Walleij <linusw@kernel.org>,
	Changhuang Liang <changhuang.liang@starfivetech.com>,
	Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>,
	Alex Soo <yuklin.soo@starfivetech.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] pinctrl: starfive: fix missing CONFIG_OF dependencies
Date: Fri,  2 Oct 2026 14:47:15 +0200	[thread overview]
Message-ID: <20261002124722.3545736-1-arnd@kernel.org> (raw)

From: Arnd Bergmann <arnd@arndb.de>

The common driver portion requires CONFIG_OF, but the drivers
selecting it do not, so we get random warnings:

WARNING: unmet direct dependencies detected for PINCTRL_STARFIVE_JHB100
  Depends on [n]: PINCTRL [=y] && OF [=n]
  Selected by [y]:
  - PINCTRL_STARFIVE_JHB100_PER1 [=y] && PINCTRL [=y] && (ARCH_STARFIVE || COMPILE_TEST [=y])
  - PINCTRL_STARFIVE_JHB100_PER2POK [=y] && PINCTRL [=y] && (ARCH_STARFIVE || COMPILE_TEST [=y])
  - PINCTRL_STARFIVE_JHB100_SYS1 [=y] && PINCTRL [=y] && (ARCH_STARFIVE || COMPILE_TEST [=y])
  Selected by [m]:
  - PINCTRL_STARFIVE_JHB100_PER0 [=m] && PINCTRL [=y] && (ARCH_STARFIVE || COMPILE_TEST [=y])
  - PINCTRL_STARFIVE_JHB100_SYS0 [=m] && PINCTRL [=y] && (ARCH_STARFIVE || COMPILE_TEST [=y])

Apparently the problem is selecting CONFIG_OF_GPIO, which is a mistake
the newly added driver copied from others. This was recently cleaned up
with commit e785c990adcc ("pinctrl: Kconfig: drop unneeded dependencies
on OF_GPIO"). Do the same here for consistency and to avoid the warning.

Fixes: 9c4d0c8fc4c1 ("pinctrl: starfive: Add StarFive JHB100 sys0 controller driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/pinctrl/starfive/Kconfig | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/pinctrl/starfive/Kconfig b/drivers/pinctrl/starfive/Kconfig
index 11bd429b45b7..7ff506a15dd8 100644
--- a/drivers/pinctrl/starfive/Kconfig
+++ b/drivers/pinctrl/starfive/Kconfig
@@ -50,11 +50,9 @@ config PINCTRL_STARFIVE_JH7110_AON
 
 config PINCTRL_STARFIVE_JHB100
 	bool
-	depends on OF
 	select GENERIC_PINCTRL
 	select GPIOLIB
 	select GPIOLIB_IRQCHIP
-	select OF_GPIO
 
 config PINCTRL_STARFIVE_JHB100_PER0
 	tristate "StarFive JHB100 SoC Peripheral-0 pinctrl and GPIO driver"
-- 
2.53.0


             reply	other threads:[~2026-10-02 12:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02 12:47 Arnd Bergmann [this message]
2026-10-02 14:23 ` [PATCH] pinctrl: starfive: fix missing CONFIG_OF dependencies Changhuang Liang
2026-10-02 21:47 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261002124722.3545736-1-arnd@kernel.org \
    --to=arnd@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=changhuang.liang@starfivetech.com \
    --cc=lianfeng.ouyang@starfivetech.com \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yuklin.soo@starfivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.