From: linuxtestproject.agent@gmail.com
To: Wake Liu <wakel@google.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] keyctl: Fix struct keyctl_dh_params build on Bionic
Date: Fri, 2 Oct 2026 13:44:13 +0000 [thread overview]
Message-ID: <20261002134413.11862-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20261002130546.1236713-1-wakel@google.com>
Hi Wake,
On Fri, 2 Oct 2026, Wake Liu wrote:
> keyctl: Fix struct keyctl_dh_params build on Bionic
Verdict - Reviewed
Pre-existing issue (low severity, not introduced by this patch):
In include/lapi/keyctl.h:55-56, keyctl_join_session_keyring() uses
KEYCTL_JOIN_SESSION_KEYRING before its fallback definition. When
HAVE_LINUX_KEYCTL_H is unset, including this header fails to compile;
the same failure occurs with the parent commit. Move the fallback
definition before the helper in a separate change.
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-10-02 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 13:05 [LTP] [PATCH] keyctl: Fix struct keyctl_dh_params build on Bionic Wake Liu via ltp
2026-10-02 13:44 ` linuxtestproject.agent [this message]
2026-10-07 9:59 ` Petr Vorel
2026-10-13 16:04 ` Petr Vorel
2026-10-12 11:49 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002134413.11862-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=wakel@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.