Re: [PATCH net-next v2] dt-bindings: net: Convert HiSilicon hns-dsaf to DT schema

[Rob Herring <robh@kernel.org>]

On Fri, Oct 02, 2026 at 09:13:40AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
> - [Medium] dt-bindings: additionalProperties false ignores properties from $ref
> - [Medium] dt-bindings: missing required properties desc-num, buf-size and subctrl-syscon
> - [Low] dt-bindings: driver still uses removed top-level phy-handle property
> --
> 
> commit d25b601aef3405df25a4432415cfd3e767a90222
> Author: Rob Herring (Arm) <robh@kernel.org>
> Subject: dt-bindings: net: Convert HiSilicon hns-dsaf to DT schema
> 
> This commit converts the HiSilicon hns-dsaf device tree binding from
> the old text format to the new YAML schema format. It drops the
> top-level phy-handle property and adds the media-type property.
> 
> > Convert the HiSilicon hns-dsaf binding to DT schema format.
> > 
> > Drop 'phy-handle' at top level as there are no users. Add undocumented
> > 'media-type' property.
> 
> [Severity: Low]
> Is it entirely accurate that there are no users of the top-level
> phy-handle property?

Yes, there are no .dts users. It is not even clear if these platforms 
are even being used. HiSilicon folks can add it back if they care.

> 
> Looking at hns_mac_init_phy_handle() in
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c:
> 
>     np = of_parse_phandle(mac_cb->dev->of_node, "phy-handle",
>                           mac_cb->mac_id);
> 
> The driver still explicitly parses this property from the top-level DSAF
> node as a fallback if port subnodes are not present. Removing this from
> the schema without removing the fallback logic in the driver will cause
> out-of-tree or legacy device trees relying on this feature to needlessly
> fail schema validation.
> 
> Should it remain in the schema (possibly marked as deprecated) until the
> C driver is patched to drop support entirely?
> 
> [ ... ]
> > diff --git a/Documentation/devicetree/bindings/net/hisilicon,hns-dsaf-v1.yaml b/Documentation/devicetree/bindings/net/hisilicon,hns-dsaf-v1.yaml
> > new file mode 100644
> > index 0000000000000..36251b45abeb9
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/hisilicon,hns-dsaf-v1.yaml
> [ ... ]
> > +patternProperties:
> > +  "^port@[0-5]$":
> > +    description: DSA Fabric port node
> > +    $ref: ethernet-switch-port.yaml#
> > +    additionalProperties: false
> 
> [Severity: Medium]
> Does additionalProperties: false correctly allow properties inherited
> from the $ref?
> 
> Under JSON Schema semantics, additionalProperties only restricts the
> properties explicitly listed in the local object, completely ignoring
> any properties evaluated via a $ref.
> 
> Would it be better to use unevaluatedProperties: false here so standard
> Ethernet port properties aren't incorrectly rejected by dt_binding_check
> when present in the device tree?

There aren't any properties from ethernet-controller.yaml used. Again, 
old platform, no new users, and possibly unused.

Rob