From: Bjorn Helgaas <helgaas@kernel.org>
To: Lorenzo Bianconi <lorenzo.bianconi@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Linus Walleij <linusw@kernel.org>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chaitanya Chundru" <krishna.chundru@oss.qualcomm.com>,
"Bartosz Golaszewski" <brgl@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Michael Walle" <mwalle@kernel.org>,
"Alex Elder" <elder@riscstar.com>,
"Daniel Thompson" <daniel@riscstar.com>,
"Sushrut Shree Trivedi" <sushrut.trivedi@oss.qualcomm.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org,
"Manivannan Sadhasivam" <manivannan.sadhasivam@oss.qualcomm.com>,
"Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
"Abel Vesa" <abel.vesa@oss.qualcomm.com>
Subject: Re: [PATCH v5 0/5] PCI/pwrctrl: tc9563: Introduce support for embedded GPIO controller
Date: Fri, 2 Oct 2026 12:54:05 -0500 [thread overview]
Message-ID: <20261002175405.GA189401@bhelgaas> (raw)
In-Reply-To: <20260923204350.GA1939701@bhelgaas>
[cc->to: Bjorn A for arm64 DTS, Linus, Bart for immutable branch question]
On Wed, Sep 23, 2026 at 03:43:50PM -0500, Bjorn Helgaas wrote:
> On Wed, Sep 09, 2026 at 04:55:52PM +0200, Lorenzo Bianconi wrote:
> > The TC9563 embeds a GPIO controller currently used for per-port reset
> > signals.
> > Add a driver for the GPIO controller embedded in the Toshiba TC9563 PCIe
> > switch providing 37 GPIO lines. The controller is registered as an auxiliary
> > device by the TC9563 power controller driver and accessed through the same
> > i2c device.
> > Please note this series is based on pwrctrl upstream branch.
> ...
> > ---
> > Alex Elder (1):
> > gpio: tc9563: Add support for the embedded GPIO controller
> >
> > Lorenzo Bianconi (4):
> > dt-bindings: PCI: toshiba,tc9563: Document embedded GPIO controller
> > PCI/pwrctrl: tc9563: Add GPIO auxiliary device support
> > PCI/pwrctrl: tc9563: Switch per-port reset to GPIO descriptor API
> > arm64: dts: qcom: qcs6490-rb3gen2: Enable TC9563 embedded GPIO controller
> >
> > .../devicetree/bindings/pci/toshiba,tc9563.yaml | 14 +-
> > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 7 +-
> > drivers/gpio/Kconfig | 11 ++
> > drivers/gpio/Makefile | 1 +
> > drivers/gpio/gpio-tc9563.c | 99 +++++++++++++
> > drivers/pci/pwrctrl/Kconfig | 1 +
> > drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c | 165 +++++++++++++++++++--
> > include/linux/soc/qcom/tc9563.h | 19 +++
> > 8 files changed, 300 insertions(+), 17 deletions(-)
> > ---
> > base-commit: 028f86457e822ab9de5b0d6d23efddc1b8b54ae1
> > change-id: 20260731-pci-tc9563-aux-66a29d438f60
>
> Applied on pci/pwrctrl for v7.4, thank you!
I had applied the arch/arm64 DTS change:
arm64: dts: qcom: qcs6490-rb3gen2: Enable TC9563 embedded GPIO controller
on pci/pwrctrl, but I think that was a mistake because that should be
handled by Bjorn Andersson instead.
What I would *like* to do is rework the pci/pwrctrl branch to drop
patch 5/5 (the arch/arm64 DTS change) and reorder the Alex's new gpio
driver first so it's not in the middle of the tc9563 DT and driver
updates:
gpio: tc9563: Add support for the embedded GPIO controller
dt-bindings: PCI: toshiba,tc9563: Document embedded GPIO controller
PCI/pwrctrl: tc9563: Add GPIO auxiliary device support
PCI/pwrctrl: tc9563: Switch per-port reset to GPIO descriptor API
But I don't want to break anybody who assumed pci/pwrctrl was
immutable and pulled it in already, e.g., to the GPIO tree. Would
this rework break anybody?
next prev parent reply other threads:[~2026-10-02 17:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 14:55 [PATCH v5 0/5] PCI/pwrctrl: tc9563: Introduce support for embedded GPIO controller Lorenzo Bianconi
2026-09-09 14:55 ` [PATCH v5 1/5] dt-bindings: PCI: toshiba,tc9563: Document " Lorenzo Bianconi
2026-09-09 15:04 ` sashiko-bot
2026-09-09 15:38 ` Lorenzo Bianconi
2026-09-11 7:29 ` Krzysztof Kozlowski
2026-09-09 14:55 ` [PATCH v5 2/5] gpio: tc9563: Add support for the " Lorenzo Bianconi
2026-09-09 15:06 ` sashiko-bot
2026-09-22 16:18 ` Manivannan Sadhasivam
2026-09-22 20:06 ` Linus Walleij
2026-09-23 14:44 ` Bartosz Golaszewski
2026-09-23 18:52 ` Bjorn Helgaas
2026-09-23 18:59 ` Alex Elder
2026-09-23 20:02 ` Bjorn Helgaas
2026-09-23 20:29 ` Lorenzo Bianconi
2026-09-09 14:55 ` [PATCH v5 3/5] PCI/pwrctrl: tc9563: Add GPIO auxiliary device support Lorenzo Bianconi
2026-09-09 15:15 ` sashiko-bot
2026-09-09 15:42 ` Lorenzo Bianconi
2026-09-09 14:55 ` [PATCH v5 4/5] PCI/pwrctrl: tc9563: Switch per-port reset to GPIO descriptor API Lorenzo Bianconi
2026-09-09 15:05 ` sashiko-bot
2026-09-09 14:55 ` [PATCH v5 5/5] arm64: dts: qcom: qcs6490-rb3gen2: Enable TC9563 embedded GPIO controller Lorenzo Bianconi
2026-09-09 15:05 ` sashiko-bot
2026-09-22 16:16 ` Manivannan Sadhasivam
2026-09-23 20:43 ` [PATCH v5 0/5] PCI/pwrctrl: tc9563: Introduce support for " Bjorn Helgaas
2026-10-02 17:54 ` Bjorn Helgaas [this message]
2026-10-02 19:18 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002175405.GA189401@bhelgaas \
--to=helgaas@kernel.org \
--cc=abel.vesa@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=bhelgaas@google.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@riscstar.com \
--cc=devicetree@vger.kernel.org \
--cc=elder@riscstar.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.bianconi@oss.qualcomm.com \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=mwalle@kernel.org \
--cc=robh@kernel.org \
--cc=sushrut.trivedi@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.