Re: [char-misc:char-misc-testing 19/37] kismet: WARNING: unmet direct dependencies detected for PCI_DYNAMIC_OF_NODES when selected by TC9564_PCI

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Thu, Oct 01, 2026 at 08:16:33PM -0500, Alex Elder wrote:
> On 10/1/26 6:52 PM, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-testing
> > head:   04434a1d0f311d76b1f15fa987918b471a0b8c6a
> > commit: 1304b0c47ef81cbd21e51ea0645a98104393ba49 [19/37] misc: tc9564: introduce base PCI driver
> > config: m68k-kismet-CONFIG_PCI_DYNAMIC_OF_NODES-CONFIG_TC9564_PCI-0-0 (https://download.01.org/0day-ci/archive/20261002/202610020124.ieOiopjQ-lkp@intel.com/config)
> > reproduce: (https://download.01.org/0day-ci/archive/20261002/202610020124.ieOiopjQ-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202610020124.ieOiopjQ-lkp@intel.com/
> > 
> > kismet warnings: (new ones prefixed by >>)
> > > > kismet: WARNING: unmet direct dependencies detected for PCI_DYNAMIC_OF_NODES when selected by TC9564_PCI
> >     WARNING: unmet direct dependencies detected for PCI_DYNAMIC_OF_NODES
> >       Depends on [n]: PCI [=y] && OF_IRQ [=n]
> >       Selected by [y]:
> >       - TC9564_PCI [=y] && OF [=y] && PCI [=y]
> > 
> > --
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
> 
> I'm about to send a patch that fixes this.  Greg, if you'd prefer
> I re-spin the series (or something else), please let me know.
> 
> 
> I did originally have "depends on OF_IRQ" under TC9564_PCI.
> 
> However I hit this:
> 
> error: recursive dependency detected!
>         symbol GENERIC_MSI_IRQ is selected by IRQ_MSI_LIB
>         symbol IRQ_MSI_LIB is selected by PCI_XGENE_MSI
>         symbol PCI_XGENE_MSI depends on PCI_XGENE
>         symbol PCI_XGENE depends on PCI_QUIRKS
>         symbol PCI_QUIRKS is selected by TC9564_PCI
>         symbol TC9564_PCI depends on OF_IRQ
>         symbol OF_IRQ depends on IRQ_DOMAIN
>         symbol IRQ_DOMAIN is selected by IRQ_DOMAIN_HIERARCHY
>         symbol IRQ_DOMAIN_HIERARCHY is selected by GENERIC_MSI_IRQ
> 
> So I removed that dependency and the problem went away.  I'm
> sorry I neglected to spend more time troubleshooting that.
> 
> So far I have found two options to avoid the recursive dependency:
> - Use "select OF_IRQ" rather than "depends on OF_IRQ"
> - Use "depends on OF_IRQ" but then use "depends on PCI_QUIRKS"
>   rather than "select PCI_QUIRKS"
> 
> I like the second one better.

Second one seems better to me too.  ANd a fixup patch is fine.

thanks

greg k-h