From: sashiko-bot@kernel.org
To: "Dawid Glazik" <dawid.glazik@linux.intel.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: arm: aspeed: Add Intel JNCRP board
Date: Sat, 03 Oct 2026 01:33:09 +0000 [thread overview]
Message-ID: <20261003013310.1B3AC1F00899@smtp.kernel.org> (raw)
In-Reply-To: <212171467173c9af64b3f8ecddca2a445b7e7148.1790344811.git.dawid.glazik@linux.intel.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: unsorted compatible string intel,jncrp-bmc
--
commit 63032ee44f7295eca9a0a28d9b29cc74a0daecb5
Author: Dawid Glazik <dawid.glazik@linux.intel.com>
dt-bindings: arm: aspeed: Add Intel JNCRP board
This commit adds a new compatible string for the Intel JNCRP BMC board to the
Aspeed device tree bindings.
> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> index 2c8180e49b2f3..6f7d77efb30c4 100644
> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> @@ -107,6 +107,7 @@ properties:
> - ibm,sbp1-bmc
> - ibm,system1-bmc
> - intel,avcrp-bmc
> + - intel,jncrp-bmc
[Severity: Low]
This isn't a bug, but should this compatible string be inserted in alphabetical
order?
The new string intel,jncrp-bmc is inserted before ibm,tacoma-bmc, which breaks
the standard alphabetical ordering of the enum list.
> - ibm,tacoma-bmc
> - inventec,starscream-bmc
> - inventec,transformer-bmc
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790344811.git.dawid.glazik@linux.intel.com?part=2
next prev parent reply other threads:[~2026-10-03 1:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 16:32 [PATCH 0/4] arm: dts: aspeed: add Intel AVCRP and JNCRP BMC platforms Dawid Glazik
2026-10-02 16:32 ` [PATCH 1/4] dt-bindings: arm: aspeed: Add Intel AVCRP board Dawid Glazik
2026-10-03 1:33 ` sashiko-bot
2026-10-03 14:40 ` Krzysztof Kozlowski
2026-10-02 16:32 ` [PATCH 2/4] dt-bindings: arm: aspeed: Add Intel JNCRP board Dawid Glazik
2026-10-03 1:33 ` sashiko-bot [this message]
2026-10-03 14:41 ` Krzysztof Kozlowski
2026-10-02 16:32 ` [PATCH 3/4] ARM: dts: aspeed: add Intel AVCRP BMC Dawid Glazik
2026-10-03 1:33 ` sashiko-bot
2026-10-03 14:42 ` Krzysztof Kozlowski
2026-10-04 21:20 ` Andrew Lunn
2026-10-02 16:32 ` [PATCH 4/4] ARM: dts: aspeed: add Intel JNCRP BMC Dawid Glazik
2026-10-04 21:21 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261003013310.1B3AC1F00899@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dawid.glazik@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.