Re: [PATCH net-next v2 10/12] net: dsa: rzn1-a5psw: Add fixed frame length workaround for management port

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] build: -Wdiscarded-qualifiers on of_data assignment
--

commit c1982503d53e92d2bb0e481c0cef9b75fe397c5c
Author: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

net: dsa: rzn1-a5psw: Add fixed frame length workaround for management port

This commit adds a workaround for an ETHSW IP issue in SoCs like RZ/T2H where
the internal mgmt_tag_vld signal is asserted as a level instead of a pulse.
It provides a way to set a fixed maximum frame length on the management port
to prevent valid frames from being dropped.

> diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c
> index 0b0b4055e6155..ce931442d49fd 100644
> --- a/drivers/net/dsa/rzn1_a5psw.c
> +++ b/drivers/net/dsa/rzn1_a5psw.c
> @@ -209,8 +209,13 @@ static int a5psw_port_enable(struct dsa_switch *ds, int port,
>  static int a5psw_port_change_mtu(struct dsa_switch *ds, int port, int new_mtu)
>  {
>  	struct a5psw *a5psw = ds->priv;
> +	struct a5psw_of_data *of_data = a5psw->of_data;

[Severity: Low]
Does this assignment cause a compiler warning for discarding qualifiers?

In struct a5psw, of_data is defined as const:

struct a5psw {
    ...
    const struct a5psw_of_data *of_data;
    ...
};

Assigning it to a non-const local pointer here causes a -Wdiscarded-qualifiers
warning, which might break builds that treat warnings as errors. Should this
local pointer be declared as const?

> +
> +	if (dsa_is_cpu_port(ds, port) && of_data->management_port_fixed_frame_len)
> +		return 0;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261001154326.754314-1-prabhakar.mahadev-lad.rj@bp.renesas.com?part=10