Re: [PATCH v1 02/13] perf python: Quietly stop processing events when a callback raises

[sashiko-bot@kernel.org]

> When a session callback raises a python exception the callback returned
> -1 causing reader__read_event() to print a "processing failed for event
> of type: ..." error. This is redundant with the python exception that is
> raised from process_events(), and corrupts the display of a TUI that
> raises from a callback to deliberately stop processing, such as when
> cancelling a background load.
> 
> Instead set session_done so that processing stops and return success,
> the pending exception is then raised by process_events(). As a single
> event may still cause further callbacks, for example multiple
> call_return callbacks followed by a sample callback, skip calling python
> while an exception is pending.
> 
> The session whose callback raised resets session_done after processing
> so later sessions process all their events. As session_done is a global,
> a session processed concurrently in another thread may be stopped early
> too. Count the stop requests so that such a session raises an error
> rather than silently dropping events.
> 
> Assisted-by: Antigravity:gemini-3.1-pro
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261002182624.3259797-1-irogers@google.com?part=2