From: sashiko-bot@kernel.org
To: "Alireza Haghdoost" <haghdoost@uber.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v4 1/5] perf symbols: Fix broken ELF_C_READ_MMAP fallback guard
Date: Sat, 03 Oct 2026 01:33:38 +0000 [thread overview]
Message-ID: <20261003013339.5600C1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20261002-perf-symbol-memory-send-v4-1-0a592bb2539e@uber.com>
> From: Alireza Haghdoost <haghdoost@uber.com>
>
> Commit 22dd1ac91a77 ("tools: Remove feature-libelf-mmap feature
> detection") replaced perf's compile-time feature test with an #ifdef on
> ELF_C_READ_MMAP. ELF_C_READ_MMAP is an Elf_Cmd enumerator rather than a
> preprocessor macro, so the condition is always false and perf silently
> uses ELF_C_READ.
>
> Perf already requires a sufficiently recent elfutils version that
> provides ELF_C_READ_MMAP. Use the enumerator directly instead of
> restoring a feature probe or retaining an unreachable fallback.
>
> Fixes: 22dd1ac91a77 ("tools: Remove feature-libelf-mmap feature detection")
> Signed-off-by: Alireza Haghdoost <haghdoost@uber.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261002-perf-symbol-memory-send-v4-0-0a592bb2539e@uber.com?part=1
next prev parent reply other threads:[~2026-10-03 1:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 18:45 [PATCH v4 0/5] perf script: Lazy symbol loading Alireza Haghdoost
2026-10-02 18:45 ` Alireza Haghdoost via B4 Relay
2026-10-02 18:45 ` [PATCH v4 1/5] perf symbols: Fix broken ELF_C_READ_MMAP fallback guard Alireza Haghdoost
2026-10-02 18:45 ` Alireza Haghdoost via B4 Relay
2026-10-02 22:08 ` Ian Rogers
2026-10-03 1:33 ` sashiko-bot [this message]
2026-10-02 18:45 ` [PATCH v4 2/5] perf dso: Allow reading DSO data from an explicit file Alireza Haghdoost
2026-10-02 18:45 ` Alireza Haghdoost via B4 Relay
2026-10-02 22:13 ` Ian Rogers
2026-10-02 23:25 ` Alireza Haghdoost
2026-10-03 1:33 ` sashiko-bot
2026-10-02 18:45 ` [PATCH v4 3/5] perf symbols: Factor out duplicate symbol selection Alireza Haghdoost
2026-10-02 18:45 ` Alireza Haghdoost via B4 Relay
2026-10-02 22:16 ` Ian Rogers
2026-10-02 23:28 ` Alireza Haghdoost
2026-10-03 1:33 ` sashiko-bot
2026-10-02 18:45 ` [PATCH v4 4/5] perf script: Add --lazy-load-symbols for lazy symbol loading Alireza Haghdoost
2026-10-02 18:45 ` Alireza Haghdoost via B4 Relay
2026-10-02 22:39 ` Ian Rogers
2026-10-02 23:52 ` Alireza Haghdoost
2026-10-03 1:33 ` sashiko-bot
2026-10-02 18:45 ` [PATCH v4 5/5] perf test: Test " Alireza Haghdoost
2026-10-02 18:45 ` Alireza Haghdoost via B4 Relay
2026-10-03 1:33 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261003013339.5600C1F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=haghdoost@uber.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.