From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2837B38D3ED for ; Sat, 3 Oct 2026 01:34:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790991263; cv=none; b=FEVclV8ZJo5LBJlokQZoGIiQkDPluKzBanBW16yfgfV8MHI22iFKx9PZTv0JpN3CwI09ujWPUT1kDuKRvCxtLSjxanI1bjEobvlZctgag3g2MF//t4Q4KQ7eIGm4u7vvBtexIIojHqZo+W8XVCzysSbQD4L/2KawQYjo5HBg/1E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790991263; c=relaxed/simple; bh=dp8VyXTYCjr0888oCgwtHXQ7r5/vKbtII0vRpG6MkF0=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=EtpFL//XqjfAXDsyjfLXntWbqY/OG953eyJj/rqPjGMtkXZH7h5iypPNQuFzmA2GpPJYrwjtnALYdfFji77t83suwFviIrzmDsbBehbhTjuL3uLDaizrCvoc6ZVpBkbA9iw4rTSYxXdn6YuG3/BtH+Jq770e19c2ouvozNWVVmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=O0Bz+tgh; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="O0Bz+tgh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC2691F00898; Sat, 3 Oct 2026 01:34:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790991261; bh=dp8VyXTYCjr0888oCgwtHXQ7r5/vKbtII0vRpG6MkF0=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=O0Bz+tghKYNgdJNgETuU/RJsfd6hAvzLN943+lzM/yMkMM6ObeM5nhb+0vxXo6FqM EOe5tPdOR4p+dzcl5JCvZ75CgiB8PvsHKygOhytwPWN//5mgQgnGatBmFSLALKVhdM YFCIwUa+hNYFn7Oo2EDOvWCb4LaIHwlcWqTamaLr9kUQaGxJfZNOrLFK4i/aCErc7F Nmu4KW1nGD6veo74k1N4lpU6oTGiO1nsLNEFiMyFPd6iCR1fPEH3XZMoyNLORKcIZh vdQUcjbNmlnnammRD8niFqz+rRzdJm8Q22hf+UfQLc0D5gDG8b/C6oX672oEnew+IH 37lKif0barwbw== From: sashiko-bot@kernel.org Subject: Re: [f2fs-dev] [PATCH v17 14/21] xfs: don't remove written extents past EOF on fsverity inodes Reply-To: sashiko-reviews@lists.linux.dev To: "Andrey Albershteyn via Linux-f2fs-devel" Cc: dsterba@suse.cz, tytso@mit.edu, linux-ext4@vger.kernel.org In-Reply-To: <20261002223705.2175542-15-aalbersh@kernel.org> References: <20261002223705.2175542-1-aalbersh@kernel.org> <20261002223705.2175542-15-aalbersh@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 03 Oct 2026 01:34:21 +0000 Message-Id: <20261003013421.AC2691F00898@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > xfs_free_eofblocks() removes all extents past EOF unless the > XFS_DIFLAG_PREALLOC or XFS_DIFLAG_APPEND flags are set. This is > undesired for fsverity as it stores metadata beyond EOF. However, while > merkle tree is being built, delayed preallocation and unwritten extents > are used. After metadata construction is done, fsverity inodes becomes > read-only and won't be changed anymore, none of these unwritten extents > or preallocations in post EOF region will be used. >=20 > Let xfs_free_eofblocks() be called on fsverity inode as usual to remove > anything which is not written extent. However, inodes which are > undergoing merkle tree construction need to be skipped in case reclaim > takes place. >=20 > Signed-off-by: Andrey Albershteyn Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261002223705.2175= 542-1-aalbersh@kernel.org?part=3D14 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1143CA5FE4 for ; Sat, 3 Oct 2026 01:34:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Cc:Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive :List-Unsubscribe:List-Id:Subject:Message-Id:Date:References:In-Reply-To:To: Sender:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JgQsNphWhi7G8Rx0AK80fqWp8YYveuNEhBMrVAOA+W4=; b=O5BgW0zrjnh6mlQlnw4z7niJ6+ afQWG+h7kpfrti7A60Bz17DZebqydlvbqqBAeSnbG65A7Ov7XpCi50mlkqOsAUTdIsprQJufHLrgP DQUThGGBRwZ5TMzrHap2r4ZpRjxDl//LBEkfbKEa39lBjnzbw1boTfDc73NxDJ+MGPOM=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1xCodw-0007AI-S3; Sat, 03 Oct 2026 01:34:29 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1xCodv-0007AA-Gd for linux-f2fs-devel@lists.sourceforge.net; Sat, 03 Oct 2026 01:34:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Cc:To:Reply-To:Subject:From:Sender: MIME-Version:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dp8VyXTYCjr0888oCgwtHXQ7r5/vKbtII0vRpG6MkF0=; b=XGXjFgYP9nlqCE1SpDePFoKjg2 obUzTlNdjHB1Gaf7VFljkHjtDhPiDnHx6M1GFm8zGaGgm6Ey7ExLu5QhDjHNcz9plAcmAxN6szuyY 05/eRUTn/vvfXkW/d/Wk6RK+PvthYZH1Myl/TiaLZq7okbAdo9yguNtATnyCdQ92p7Es=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Content-Transfer-Encoding:Content-Type:References: In-Reply-To:Cc:To:Reply-To:Subject:From:Sender:MIME-Version:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=dp8VyXTYCjr0888oCgwtHXQ7r5/vKbtII0vRpG6MkF0=; b=Pm/4QiCs2ryFv3CLzDEAOcWJ9l jlxcPJKOlT/0mak0m+rlnnuD8ieP5UaMBaUIDqPrvvj+QfcDrsEq4gE3tGgg2mNc4z2A+97EFneyw Z+kgRJVf2qIZXLw8f3VTkopXkhC/BupQ/UV4MrwWZLN1Tqqmxkp5/yJgQL3ke8m5ZIQU=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1xCodv-0001jt-LZ for linux-f2fs-devel@lists.sourceforge.net; Sat, 03 Oct 2026 01:34:28 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 1C26C60DA2; Sat, 3 Oct 2026 01:34:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC2691F00898; Sat, 3 Oct 2026 01:34:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790991261; bh=dp8VyXTYCjr0888oCgwtHXQ7r5/vKbtII0vRpG6MkF0=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=O0Bz+tghKYNgdJNgETuU/RJsfd6hAvzLN943+lzM/yMkMM6ObeM5nhb+0vxXo6FqM EOe5tPdOR4p+dzcl5JCvZ75CgiB8PvsHKygOhytwPWN//5mgQgnGatBmFSLALKVhdM YFCIwUa+hNYFn7Oo2EDOvWCb4LaIHwlcWqTamaLr9kUQaGxJfZNOrLFK4i/aCErc7F Nmu4KW1nGD6veo74k1N4lpU6oTGiO1nsLNEFiMyFPd6iCR1fPEH3XZMoyNLORKcIZh vdQUcjbNmlnnammRD8niFqz+rRzdJm8Q22hf+UfQLc0D5gDG8b/C6oX672oEnew+IH 37lKif0barwbw== To: "Andrey Albershteyn via Linux-f2fs-devel" In-Reply-To: <20261002223705.2175542-15-aalbersh@kernel.org> References: <20261002223705.2175542-1-aalbersh@kernel.org> <20261002223705.2175542-15-aalbersh@kernel.org> Date: Sat, 03 Oct 2026 01:34:21 +0000 Message-Id: <20261003013421.AC2691F00898@smtp.kernel.org> X-Headers-End: 1xCodv-0001jt-LZ Subject: Re: [f2fs-dev] [PATCH v17 14/21] xfs: don't remove written extents past EOF on fsverity inodes X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: sashiko-bot--- via Linux-f2fs-devel Reply-To: sashiko-reviews@lists.linux.dev Cc: sashiko-bot@kernel.org, linux-ext4@vger.kernel.org, tytso@mit.edu, dsterba@suse.cz MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net PiB4ZnNfZnJlZV9lb2ZibG9ja3MoKSByZW1vdmVzIGFsbCBleHRlbnRzIHBhc3QgRU9GIHVubGVz cyB0aGUKPiBYRlNfRElGTEFHX1BSRUFMTE9DIG9yIFhGU19ESUZMQUdfQVBQRU5EIGZsYWdzIGFy ZSBzZXQuIFRoaXMgaXMKPiB1bmRlc2lyZWQgZm9yIGZzdmVyaXR5IGFzIGl0IHN0b3JlcyBtZXRh ZGF0YSBiZXlvbmQgRU9GLiBIb3dldmVyLCB3aGlsZQo+IG1lcmtsZSB0cmVlIGlzIGJlaW5nIGJ1 aWx0LCBkZWxheWVkIHByZWFsbG9jYXRpb24gYW5kIHVud3JpdHRlbiBleHRlbnRzCj4gYXJlIHVz ZWQuIEFmdGVyIG1ldGFkYXRhIGNvbnN0cnVjdGlvbiBpcyBkb25lLCBmc3Zlcml0eSBpbm9kZXMg YmVjb21lcwo+IHJlYWQtb25seSBhbmQgd29uJ3QgYmUgY2hhbmdlZCBhbnltb3JlLCBub25lIG9m IHRoZXNlIHVud3JpdHRlbiBleHRlbnRzCj4gb3IgcHJlYWxsb2NhdGlvbnMgaW4gcG9zdCBFT0Yg cmVnaW9uIHdpbGwgYmUgdXNlZC4KPiAKPiBMZXQgeGZzX2ZyZWVfZW9mYmxvY2tzKCkgYmUgY2Fs bGVkIG9uIGZzdmVyaXR5IGlub2RlIGFzIHVzdWFsIHRvIHJlbW92ZQo+IGFueXRoaW5nIHdoaWNo IGlzIG5vdCB3cml0dGVuIGV4dGVudC4gSG93ZXZlciwgaW5vZGVzIHdoaWNoIGFyZQo+IHVuZGVy Z29pbmcgbWVya2xlIHRyZWUgY29uc3RydWN0aW9uIG5lZWQgdG8gYmUgc2tpcHBlZCBpbiBjYXNl IHJlY2xhaW0KPiB0YWtlcyBwbGFjZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXkgQWxiZXJz aHRleW4gPGFhbGJlcnNoQGtlcm5lbC5vcmc+CgpTYXNoaWtvIGhhcyByZXZpZXdlZCB0aGlzIHBh dGNoIGFuZCBmb3VuZCBubyBpc3N1ZXMuIEl0IGxvb2tzIGdyZWF0IQoKLS0gClNhc2hpa28gQUkg cmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MTAwMjIyMzcwNS4y MTc1NTQyLTEtYWFsYmVyc2hAa2VybmVsLm9yZz9wYXJ0PTE0CgoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LWYyZnMtZGV2ZWwgbWFpbGluZyBs aXN0CkxpbnV4LWYyZnMtZGV2ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMu c291cmNlZm9yZ2UubmV0L2xpc3RzL2xpc3RpbmZvL2xpbnV4LWYyZnMtZGV2ZWwK