From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66858384224 for ; Sat, 3 Oct 2026 01:34:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790991265; cv=none; b=AkvaFm6F+sfmadQjzoh4VeSnbRgvfPDf6DluNn0zo8eRDglahogQfaVIMAZt4YPqyCAoKQqeD8Br3cHwNCekR+B/gAoVNdyCcLWlO571wIkSeF2R80ZcWzO7gMBkPZynTfQ7opSLrbH0Z0cN08ym70m6tEbxWf1HdPBPlqg1vYw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790991265; c=relaxed/simple; bh=71aF5Re8001dOR8w/NauwNq/Z4pyZEpGU497PZMGRWE=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=UQf70vlZoZDcToVIwzU2Bj/b8Tugb+iG5zxxPlLDoWanIcJl9q96Fkx1BDjzhDtpAgaHTCe7scRfYDIbXGZVzcMjwHd8XhYN0rCS0AxGvICk4/uOKKK4MiPFW3rLZTltf2IhHnTWTAhOtlkCpHsr+o2HEtD5lkNVWSA2P1DRnDk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jPyo05Pw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jPyo05Pw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08BC41F000FF; Sat, 3 Oct 2026 01:34:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790991264; bh=DbIzpBVN3WRd7NTzQMjDbnLE/zFKPQ+K6jvKXl2+ERU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=jPyo05PwPwv2tk+Mbzf8HcytvfQvPKrmMF9mN1+yH0DUBcBje8Swqf55aH8iZInnm HLIy2WH5eckZt4iz8A2oAMT6SIaLaqxrUyFn6zMebKngruj1JXWdZRjsXjmjBjbXOY j40HaU+B6tqhLPOY4jjmPi1kysJ+Gsu0vMnRMtMkEnBqbySry7dzkBkZstlF8Lbg7b /GiqwMA5ow/qh/hLk862lIHttlNORUAs2TjgNWHQ6kUIgTeC7Sck3O6lqkPtfk03s4 VBldvUTyB4+x/LTkleQHZjTTrH7ZI+IVKzi/4BaHx1Z+Ag3fW4//gd+3lPeMj7xIZN 7f9voUaEFjw5Q== From: sashiko-bot@kernel.org Subject: Re: [f2fs-dev] [PATCH v17 19/21] xfs: check and repair the verity inode flag state Reply-To: sashiko-reviews@lists.linux.dev To: "Andrey Albershteyn via Linux-f2fs-devel" Cc: linux-ext4@vger.kernel.org, tytso@mit.edu, dsterba@suse.cz In-Reply-To: <20261002223705.2175542-20-aalbersh@kernel.org> References: <20261002223705.2175542-1-aalbersh@kernel.org> <20261002223705.2175542-20-aalbersh@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 03 Oct 2026 01:34:23 +0000 Message-Id: <20261003013424.08BC41F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] xfs: scrub aborts on fsverity validation errors -EINVAL and -EFB= IG -- commit 856d4488769e21ab11188de2cd348b2c2b9cb631 Author: Darrick J. Wong xfs: check and repair the verity inode flag state If an inode has the incore verity iflag set, make sure that we can actually activate fsverity on that inode. If activation fails due to a fsverity metadata validation error, clear the flag. > diff --git a/fs/xfs/scrub/common.c b/fs/xfs/scrub/common.c > index e5233e31abb75..ebbef3afb7d6e 100644 > --- a/fs/xfs/scrub/common.c > +++ b/fs/xfs/scrub/common.c [ ... ] > @@ -1754,3 +1756,54 @@ xchk_inode_count_blocks( > return xfs_bmap_count_blocks(sc->tp, sc->ip, whichfork, nextents, > count); > } > + > +/* > + * If this inode has S_VERITY set on it, read the verity info. If the re= ading > + * fails with anything other than ENOMEM, the file is corrupt, which we = can > + * detect later with fsverity_active. > + * > + * Callers must hold the IOLOCK and must not hold the ILOCK of sc->ip be= cause > + * activation reads inode data. > + */ > +int > +xchk_inode_setup_verity( > + struct xfs_scrub *sc) > +{ > + int error; > + > + if (!fsverity_active(VFS_I(sc->ip))) > + return 0; > + > + error =3D fsverity_ensure_verity_info(VFS_I(sc->ip)); > + switch (error) { > + case 0: > + /* fsverity is active */ > + break; > + case -ENODATA: > + case -EMSGSIZE: > + case -EFSCORRUPTED: > + case -ERANGE: > + case -EBADMSG: > + /* > + * The nonzero errno codes above are the error codes that can > + * be returned from fsverity on metadata validation errors. > + */ > + return 0; > + default: > + /* runtime errors */ > + return error; > + } [Severity: Medium] Should -EINVAL and -EFBIG be included in the allowed validation error codes? A corrupted fsverity descriptor on disk can trigger validate_fsverity_descriptor() to return -EINVAL or fsverity_init_merkle_tree_params() to return -EFBIG. Because they are omitted from this switch statement, they fall through to t= he default case and return the error, aborting the scrub setup instead of gracefully marking the inode as broken and continuing the repair pipeline. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261002223705.2175= 542-1-aalbersh@kernel.org?part=3D19 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C6F4CA5FE9 for ; Sat, 3 Oct 2026 01:34:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Cc:Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive :List-Unsubscribe:List-Id:Subject:Message-Id:Date:References:In-Reply-To:To: Sender:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kUKKlR/q4QwYfjlz74PAfTFbyHm7hhwX+2DRElE07dg=; b=gN0p7BU2bBlE/LYDmVX/0DMp1J uIFCDi6LvD+nDPuZfj0ztrbCzhivKVqb2lmf0Q1QtlAQoagrKcLg6UnVTjgo4wHhL4I9gAUTp1FkK tNdoCgSfdBVvK01/7eflAl6p7xTWeiIgfpCsVn25tZgPh+RY8wEZGHP3/4qQepSQY8m0=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1xCoe4-0004EP-8h; Sat, 03 Oct 2026 01:34:33 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1xCoe0-0003u4-Pg for linux-f2fs-devel@lists.sourceforge.net; Sat, 03 Oct 2026 01:34:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Cc:To:Reply-To:Subject:From:Sender: MIME-Version:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=DbIzpBVN3WRd7NTzQMjDbnLE/zFKPQ+K6jvKXl2+ERU=; b=giR6f5CJ52dT92bqcKqOyLMmie b9KRjGJaZVA9LwhDTZHuHPOf0sC60HjkWHekIXqzIs9J2i5KbgOePshDVw7b8bLZbN6wiLlbxtiRS o6K4OnOTksQfdqt/KFoZ8pZB3Tj1JpthWj+Brs+1HvI4LGCNtmzjFyiRUUUZxsLnTVGk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Content-Transfer-Encoding:Content-Type:References: In-Reply-To:Cc:To:Reply-To:Subject:From:Sender:MIME-Version:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=DbIzpBVN3WRd7NTzQMjDbnLE/zFKPQ+K6jvKXl2+ERU=; b=jSn/+yzGMzsZF7Y0bCeJPC/uVl cUddBNaBxxy5Mn53UwiQj3nA4wpyNCEcmMS7N/iyoAE+qTtFRMOzelHtTq+D+aSWgEnTGqI+E2k+r MYiv+2PDxRUj9g5crOMBNED4ddrfZLvc2IWfweRZRtpg6+bO+XUSDTLm/nYYjFwIws5I=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1xCodx-0001k3-M9 for linux-f2fs-devel@lists.sourceforge.net; Sat, 03 Oct 2026 01:34:30 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 66453407FD; Sat, 3 Oct 2026 01:34:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08BC41F000FF; Sat, 3 Oct 2026 01:34:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790991264; bh=DbIzpBVN3WRd7NTzQMjDbnLE/zFKPQ+K6jvKXl2+ERU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=jPyo05PwPwv2tk+Mbzf8HcytvfQvPKrmMF9mN1+yH0DUBcBje8Swqf55aH8iZInnm HLIy2WH5eckZt4iz8A2oAMT6SIaLaqxrUyFn6zMebKngruj1JXWdZRjsXjmjBjbXOY j40HaU+B6tqhLPOY4jjmPi1kysJ+Gsu0vMnRMtMkEnBqbySry7dzkBkZstlF8Lbg7b /GiqwMA5ow/qh/hLk862lIHttlNORUAs2TjgNWHQ6kUIgTeC7Sck3O6lqkPtfk03s4 VBldvUTyB4+x/LTkleQHZjTTrH7ZI+IVKzi/4BaHx1Z+Ag3fW4//gd+3lPeMj7xIZN 7f9voUaEFjw5Q== To: "Andrey Albershteyn via Linux-f2fs-devel" In-Reply-To: <20261002223705.2175542-20-aalbersh@kernel.org> References: <20261002223705.2175542-1-aalbersh@kernel.org> <20261002223705.2175542-20-aalbersh@kernel.org> Date: Sat, 03 Oct 2026 01:34:23 +0000 Message-Id: <20261003013424.08BC41F000FF@smtp.kernel.org> X-Headers-End: 1xCodx-0001k3-M9 Subject: Re: [f2fs-dev] [PATCH v17 19/21] xfs: check and repair the verity inode flag state X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: sashiko-bot--- via Linux-f2fs-devel Reply-To: sashiko-reviews@lists.linux.dev Cc: sashiko-bot@kernel.org, linux-ext4@vger.kernel.org, tytso@mit.edu, dsterba@suse.cz MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0geGZzOiBzY3J1YiBh Ym9ydHMgb24gZnN2ZXJpdHkgdmFsaWRhdGlvbiBlcnJvcnMgLUVJTlZBTCBhbmQgLUVGQklHCi0t Cgpjb21taXQgODU2ZDQ0ODg3NjllMjFhYjExMTg4ZGUyY2QzNDhiMmMyYjljYjYzMQpBdXRob3I6 IERhcnJpY2sgSi4gV29uZyA8ZGp3b25nQGtlcm5lbC5vcmc+Cgp4ZnM6IGNoZWNrIGFuZCByZXBh aXIgdGhlIHZlcml0eSBpbm9kZSBmbGFnIHN0YXRlCgpJZiBhbiBpbm9kZSBoYXMgdGhlIGluY29y ZSB2ZXJpdHkgaWZsYWcgc2V0LCBtYWtlIHN1cmUgdGhhdCB3ZSBjYW4KYWN0dWFsbHkgYWN0aXZh dGUgZnN2ZXJpdHkgb24gdGhhdCBpbm9kZS4gIElmIGFjdGl2YXRpb24gZmFpbHMgZHVlIHRvCmEg ZnN2ZXJpdHkgbWV0YWRhdGEgdmFsaWRhdGlvbiBlcnJvciwgY2xlYXIgdGhlIGZsYWcuCgo+IGRp ZmYgLS1naXQgYS9mcy94ZnMvc2NydWIvY29tbW9uLmMgYi9mcy94ZnMvc2NydWIvY29tbW9uLmMK PiBpbmRleCBlNTIzM2UzMWFiYjc1Li5lYmJlZjNhZmI3ZDZlIDEwMDY0NAo+IC0tLSBhL2ZzL3hm cy9zY3J1Yi9jb21tb24uYwo+ICsrKyBiL2ZzL3hmcy9zY3J1Yi9jb21tb24uYwpbIC4uLiBdCj4g QEAgLTE3NTQsMyArMTc1Niw1NCBAQCB4Y2hrX2lub2RlX2NvdW50X2Jsb2NrcygKPiAgCXJldHVy biB4ZnNfYm1hcF9jb3VudF9ibG9ja3Moc2MtPnRwLCBzYy0+aXAsIHdoaWNoZm9yaywgbmV4dGVu dHMsCj4gIAkJCWNvdW50KTsKPiAgfQo+ICsKPiArLyoKPiArICogSWYgdGhpcyBpbm9kZSBoYXMg U19WRVJJVFkgc2V0IG9uIGl0LCByZWFkIHRoZSB2ZXJpdHkgaW5mby4gSWYgdGhlIHJlYWRpbmcK PiArICogZmFpbHMgd2l0aCBhbnl0aGluZyBvdGhlciB0aGFuIEVOT01FTSwgdGhlIGZpbGUgaXMg Y29ycnVwdCwgd2hpY2ggd2UgY2FuCj4gKyAqIGRldGVjdCBsYXRlciB3aXRoIGZzdmVyaXR5X2Fj dGl2ZS4KPiArICoKPiArICogQ2FsbGVycyBtdXN0IGhvbGQgdGhlIElPTE9DSyBhbmQgbXVzdCBu b3QgaG9sZCB0aGUgSUxPQ0sgb2Ygc2MtPmlwIGJlY2F1c2UKPiArICogYWN0aXZhdGlvbiByZWFk cyBpbm9kZSBkYXRhLgo+ICsgKi8KPiAraW50Cj4gK3hjaGtfaW5vZGVfc2V0dXBfdmVyaXR5KAo+ ICsJc3RydWN0IHhmc19zY3J1Ygkqc2MpCj4gK3sKPiArCWludAkJCWVycm9yOwo+ICsKPiArCWlm ICghZnN2ZXJpdHlfYWN0aXZlKFZGU19JKHNjLT5pcCkpKQo+ICsJCXJldHVybiAwOwo+ICsKPiAr CWVycm9yID0gZnN2ZXJpdHlfZW5zdXJlX3Zlcml0eV9pbmZvKFZGU19JKHNjLT5pcCkpOwo+ICsJ c3dpdGNoIChlcnJvcikgewo+ICsJY2FzZSAwOgo+ICsJCS8qIGZzdmVyaXR5IGlzIGFjdGl2ZSAq Lwo+ICsJCWJyZWFrOwo+ICsJY2FzZSAtRU5PREFUQToKPiArCWNhc2UgLUVNU0dTSVpFOgo+ICsJ Y2FzZSAtRUZTQ09SUlVQVEVEOgo+ICsJY2FzZSAtRVJBTkdFOgo+ICsJY2FzZSAtRUJBRE1TRzoK PiArCQkvKgo+ICsJCSAqIFRoZSBub256ZXJvIGVycm5vIGNvZGVzIGFib3ZlIGFyZSB0aGUgZXJy b3IgY29kZXMgdGhhdCBjYW4KPiArCQkgKiBiZSByZXR1cm5lZCBmcm9tIGZzdmVyaXR5IG9uIG1l dGFkYXRhIHZhbGlkYXRpb24gZXJyb3JzLgo+ICsJCSAqLwo+ICsJCXJldHVybiAwOwo+ICsJZGVm YXVsdDoKPiArCQkvKiBydW50aW1lIGVycm9ycyAqLwo+ICsJCXJldHVybiBlcnJvcjsKPiArCX0K CltTZXZlcml0eTogTWVkaXVtXQpTaG91bGQgLUVJTlZBTCBhbmQgLUVGQklHIGJlIGluY2x1ZGVk IGluIHRoZSBhbGxvd2VkIHZhbGlkYXRpb24gZXJyb3IgY29kZXM/CgpBIGNvcnJ1cHRlZCBmc3Zl cml0eSBkZXNjcmlwdG9yIG9uIGRpc2sgY2FuIHRyaWdnZXIKdmFsaWRhdGVfZnN2ZXJpdHlfZGVz Y3JpcHRvcigpIHRvIHJldHVybiAtRUlOVkFMIG9yCmZzdmVyaXR5X2luaXRfbWVya2xlX3RyZWVf cGFyYW1zKCkgdG8gcmV0dXJuIC1FRkJJRy4KCkJlY2F1c2UgdGhleSBhcmUgb21pdHRlZCBmcm9t IHRoaXMgc3dpdGNoIHN0YXRlbWVudCwgdGhleSBmYWxsIHRocm91Z2ggdG8gdGhlCmRlZmF1bHQg Y2FzZSBhbmQgcmV0dXJuIHRoZSBlcnJvciwgYWJvcnRpbmcgdGhlIHNjcnViIHNldHVwIGluc3Rl YWQgb2YKZ3JhY2VmdWxseSBtYXJraW5nIHRoZSBpbm9kZSBhcyBicm9rZW4gYW5kIGNvbnRpbnVp bmcgdGhlIHJlcGFpciBwaXBlbGluZS4KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczov L3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjEwMDIyMjM3MDUuMjE3NTU0Mi0xLWFhbGJlcnNo QGtlcm5lbC5vcmc/cGFydD0xOQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkxpbnV4LWYyZnMtZGV2ZWwgbWFpbGluZyBsaXN0CkxpbnV4LWYyZnMtZGV2 ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2UubmV0L2xp c3RzL2xpc3RpbmZvL2xpbnV4LWYyZnMtZGV2ZWwK