From: sashiko-bot@kernel.org
To: "Kees Cook" <kees@kernel.org>
Cc: nvdimm@lists.linux.dev, linux-trace-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH v4 06/11] seq_buf: Add seq_buf_terminate()
Date: Sat, 03 Oct 2026 04:05:53 +0000 [thread overview]
Message-ID: <20261003040553.984D71F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261003035921.1918874-6-kees@kernel.org>
> Seven callers call seq_buf_str() only to NUL-terminate the buffer,
> discarding the returned pointer. Two of them need a comment to say so.
>
> Add seq_buf_terminate(), wrapping the __seq_buf_terminate() helper that
> seq_buf_str() and seq_buf_strlen() already use, and convert those
> callers. It returns void: returning the offset would just be
> seq_buf_strlen() under another name. A zero-sized seq_buf is left
> untouched, as in the other accessors.
>
> Add tests for the three cases: room for the NUL after the data, an
> overflowed buffer where it lands in the last byte, and a zero-sized
> buffer that must not be written to.
>
> Build tested ARCH=x86_64 defconfig with GCC 16.2.0, plus
> CONFIG_HIST_TRIGGERS=y and CONFIG_BPF_SYSCALL=y to reach the converted
> call sites in kernel/trace/trace_events_hist.c and
> kernel/bpf/diagnostics.c. Tests run 24/24 passing on ARCH=um.
>
> Assisted-by: LLM
> Signed-off-by: Kees Cook <kees@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261003035906.too.263-kees@kernel.org?part=6
next prev parent reply other threads:[~2026-10-03 4:05 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-03 3:59 [PATCH v4 00/11] seq_buf: Add seq_buf_strlen() Kees Cook
2026-10-03 3:59 ` [PATCH v4 01/11] seq_buf: Do not print an empty line from an overflowed seq_buf_do_printk() Kees Cook
2026-10-03 4:07 ` sashiko-bot
2026-10-03 4:50 ` bot+bpf-ci
2026-10-03 4:50 ` bot+bpf-ci
2026-10-05 10:05 ` Kees Cook
2026-10-03 3:59 ` [PATCH v4 02/11] seq_buf: Do not pop from an overflowed seq_buf Kees Cook
2026-10-03 4:05 ` sashiko-bot
2026-10-03 3:59 ` [PATCH v4 03/11] seq_buf: Copy what fits when seq_buf_puts() and seq_buf_putmem() overflow Kees Cook
2026-10-03 4:07 ` sashiko-bot
2026-10-03 4:50 ` bot+bpf-ci
2026-10-03 4:50 ` bot+bpf-ci
2026-10-05 10:06 ` Kees Cook
2026-10-03 3:59 ` [PATCH v4 04/11] seq_buf: Clear what a writer did not claim when a seq_buf overflows Kees Cook
2026-10-03 4:07 ` sashiko-bot
2026-10-03 4:50 ` bot+bpf-ci
2026-10-03 4:50 ` bot+bpf-ci
2026-10-03 3:59 ` [PATCH v4 05/11] seq_buf: Add seq_buf_strlen() Kees Cook
2026-10-03 4:04 ` sashiko-bot
2026-10-03 15:36 ` Andy Shevchenko
2026-10-04 7:26 ` Kees Cook
2026-10-04 8:34 ` Andy Shevchenko
2026-10-05 11:22 ` Kees Cook
2026-10-05 11:34 ` Alejandro Colomar
2026-10-05 15:58 ` Kees Cook
2026-10-05 16:43 ` Alejandro Colomar
2026-10-03 3:59 ` [PATCH v4 06/11] seq_buf: Add seq_buf_terminate() Kees Cook
2026-10-03 4:05 ` sashiko-bot [this message]
2026-10-03 3:59 ` [PATCH v4 07/11] bpf: Remove dead newline stripping from format_disasm_line() Kees Cook
2026-10-03 4:05 ` sashiko-bot
2026-10-03 3:59 ` [PATCH v4 08/11] seq_buf: Add seq_buf_init_append() Kees Cook
2026-10-03 4:05 ` sashiko-bot
2026-10-03 4:33 ` bot+bpf-ci
2026-10-03 4:33 ` bot+bpf-ci
2026-10-03 10:31 ` Kees Cook
2026-10-03 3:59 ` [PATCH v4 09/11] powerpc/papr_scm: Return the string length from the sysfs show functions Kees Cook
2026-10-03 4:06 ` sashiko-bot
2026-10-03 3:59 ` [PATCH v4 10/11] nvdimm: ndtest: Return the string length from flags_show() Kees Cook
2026-10-03 4:08 ` sashiko-bot
2026-10-03 3:59 ` [PATCH v4 11/11] docs: core-api: Document the seq_buf API Kees Cook
2026-10-03 4:03 ` sashiko-bot
2026-10-03 6:32 ` [PATCH v4 00/11] seq_buf: Add seq_buf_strlen() Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261003040553.984D71F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=kees@kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.