From: kernel test robot <lkp@intel.com>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev, 0day robot <lkp@intel.com>
Subject: drivers/pinctrl/berlin/berlin.c:271:31: error: implicit declaration of function 'FIELD_GET'
Date: Sat, 03 Oct 2026 07:05:18 +0200 [thread overview]
Message-ID: <202610030734.aALYYeQ9-lkp@intel.com> (raw)
tree: https://github.com/intel-lab-lkp/linux/commits/Jisheng-Zhang/dt-bindings-serial-snps-dw-apb-uart-Add-Synaptics-sl261x-uart/20260929-141358
head: 66f26b6f0baa133e1c8c3a8afb0ef81b5001f027
commit: 36ba973f7fdc2baf760334dffccba25c685c8e89 pinctrl: berlin: add optional pinconf support
date: 4 days ago
config: xtensa-randconfig-r2105-20261003 (https://download.01.org/0day-ci/archive/20261003/202610030734.aALYYeQ9-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261003/202610030734.aALYYeQ9-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610030734.aALYYeQ9-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/pinctrl/berlin/berlin.c: In function 'berlin_pinconf_group_get':
>> drivers/pinctrl/berlin/berlin.c:271:31: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]
271 | val = FIELD_GET(PINCFG_DS_10BIT, val);
| ^~~~~~~~~
vim +/FIELD_GET +271 drivers/pinctrl/berlin/berlin.c
217
218 static int berlin_pinconf_group_get(struct pinctrl_dev *pctrl_dev,
219 unsigned int group, unsigned long *configs)
220 {
221 enum pin_config_param param = pinconf_to_config_param(*configs);
222 struct berlin_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctrl_dev);
223 const struct berlin_desc_group *group_desc = pctrl->desc->groups + group;
224 bool enabled;
225 u32 val;
226 int ret;
227 u8 conf_bits = group_desc->conf_bits;
228
229 if (!conf_bits)
230 return -EOPNOTSUPP;
231
232 ret = regmap_read(pctrl->regmap, group_desc->conf_offset, &val);
233 if (ret)
234 return ret;
235
236 switch (param) {
237 case PIN_CONFIG_BIAS_DISABLE:
238 if (conf_bits == 10)
239 enabled = !(val & PINCFG_PE_10BIT);
240 else
241 enabled = !(val & (PINCFG_PD_8BIT | PINCFG_PU_8BIT));
242 val = 0;
243 break;
244 case PIN_CONFIG_BIAS_PULL_DOWN:
245 if (conf_bits == 10)
246 enabled = (val & (PINCFG_PE_10BIT | PINCFG_PS_10BIT)) == PINCFG_PE_10BIT;
247 else
248 enabled = val & PINCFG_PD_8BIT;
249 val = enabled ? 1 : 0;
250 break;
251 case PIN_CONFIG_BIAS_PULL_UP:
252 if (conf_bits == 10) {
253 if ((val & (PINCFG_PE_10BIT | PINCFG_PS_10BIT)) == (PINCFG_PE_10BIT | PINCFG_PS_10BIT)) {
254 enabled = true;
255 if (val & PINCFG_SPU_10BIT)
256 val = 2;
257 else
258 val = 1;
259 } else {
260 enabled = false;
261 val = 0;
262 }
263 } else {
264 enabled = val & PINCFG_PU_8BIT;
265 val = enabled ? 1 : 0;
266 }
267 break;
268 case PIN_CONFIG_DRIVE_STRENGTH:
269 enabled = true;
270 if (conf_bits == 10)
> 271 val = FIELD_GET(PINCFG_DS_10BIT, val);
272 else
273 val = FIELD_GET(PINCFG_DS_8BIT, val);
274 break;
275 case PIN_CONFIG_INPUT_ENABLE:
276 if (conf_bits == 10)
277 enabled = val & PINCFG_IE_10BIT;
278 else
279 enabled = val & PINCFG_IE_8BIT;
280 val = enabled ? 1 : 0;
281 break;
282 case PIN_CONFIG_INPUT_SCHMITT_ENABLE:
283 if (conf_bits == 10)
284 enabled = val & PINCFG_ST_10BIT;
285 else
286 enabled = val & PINCFG_ST_8BIT;
287 val = enabled ? 1 : 0;
288 break;
289 case PIN_CONFIG_SLEW_RATE:
290 if (conf_bits == 10)
291 enabled = val & PINCFG_SL_10BIT;
292 else
293 enabled = val & PINCFG_SL_8BIT;
294 val = enabled ? 1 : 0;
295 break;
296 default:
297 return -EOPNOTSUPP;
298 }
299
300 *configs = pinconf_to_config_packed(param, val);
301 return enabled ? 0 : -EINVAL;
302 }
303
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-10-03 5:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202610030734.aALYYeQ9-lkp@intel.com \
--to=lkp@intel.com \
--cc=jszhang@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.