All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: drivers/net/ethernet/korina.c:1235 korina_open() warn: 'lp->rx_irq' from request_irq() not released on lines: 1229.
Date: Sat, 03 Oct 2026 09:40:16 +0200	[thread overview]
Message-ID: <202610030925.IEUthiBx-lkp@intel.com> (raw)

Unfiltered warning: this smatch report is sent as-is and has not been
reviewed for false positives, so please treat it with due skepticism.

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Yang Wen <anmuxixixi@gmail.com>
CC: Namjae Jeon <linkinjeon@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   e767a4ea70a3992c37ed604157d32f0dfbf9b1e3
commit: 27af3392196ddfa4c212f4c883b9964a6dcd5f95 exfat: fix truncated volume labels returned by FS_IOC_GETFSLABEL
date:   8 weeks ago
:::::: branch date: 7 hours ago
:::::: commit date: 8 weeks ago
config: m68k-randconfig-r2202-20261003 (https://download.01.org/0day-ci/archive/20261003/202610030925.IEUthiBx-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.5.0
smatch: v0.5.0-9187-g5189e3fb

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 27af3392196d ("exfat: fix truncated volume labels returned by FS_IOC_GETFSLABEL")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202610030925.IEUthiBx-lkp@intel.com/

smatch warnings:
drivers/net/ethernet/korina.c:1235 korina_open() warn: 'lp->rx_irq' from request_irq() not released on lines: 1229.

vim +1235 drivers/net/ethernet/korina.c

ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1197  
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1198  static int korina_open(struct net_device *dev)
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1199  {
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1200  	struct korina_private *lp = netdev_priv(dev);
e3152ab901bcec drivers/net/korina.c          Francois Romieu    2008-04-20  1201  	int ret;
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1202  
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1203  	/* Initialize */
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1204  	ret = korina_init(dev);
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1205  	if (ret < 0) {
f16aea4d201018 drivers/net/korina.c          Phil Sutter        2009-08-12  1206  		printk(KERN_ERR "%s: cannot open device\n", dev->name);
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1207  		goto out;
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1208  	}
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1209  
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1210  	/* Install the interrupt handler
7ce103b4cbb20b drivers/net/ethernet/korina.c Roman Yeryomin     2017-09-17  1211  	 * that handles the Done Finished */
a0607fd3a25ba1 drivers/net/korina.c          Joe Perches        2009-11-18  1212  	ret = request_irq(lp->rx_irq, korina_rx_dma_interrupt,
2414fe16ddf557 drivers/net/ethernet/korina.c Michael Opdenacker 2013-09-07  1213  			0, "Korina ethernet Rx", dev);
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1214  	if (ret < 0) {
f16aea4d201018 drivers/net/korina.c          Phil Sutter        2009-08-12  1215  		printk(KERN_ERR "%s: unable to get Rx DMA IRQ %d\n",
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1216  			dev->name, lp->rx_irq);
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1217  		goto err_release;
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1218  	}
a0607fd3a25ba1 drivers/net/korina.c          Joe Perches        2009-11-18  1219  	ret = request_irq(lp->tx_irq, korina_tx_dma_interrupt,
2414fe16ddf557 drivers/net/ethernet/korina.c Michael Opdenacker 2013-09-07  1220  			0, "Korina ethernet Tx", dev);
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1221  	if (ret < 0) {
f16aea4d201018 drivers/net/korina.c          Phil Sutter        2009-08-12  1222  		printk(KERN_ERR "%s: unable to get Tx DMA IRQ %d\n",
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1223  			dev->name, lp->tx_irq);
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1224  		goto err_free_rx_irq;
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1225  	}
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1226  
4d5ef9f0f58804 drivers/net/korina.c          Florian Fainelli   2009-05-28  1227  	mod_timer(&lp->media_check_timer, jiffies + 1);
751c2e47550274 drivers/net/korina.c          Francois Romieu    2008-04-20  1228  out:
751c2e47550274 drivers/net/korina.c          Francois Romieu    2008-04-20  1229  	return ret;
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1230  
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1231  err_free_rx_irq:
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1232  	free_irq(lp->rx_irq, dev);
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1233  err_release:
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1234  	korina_free_ring(dev);
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19 @1235  	goto out;
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1236  }
ef11291bcd5f96 drivers/net/korina.c          Florian Fainelli   2008-03-19  1237  

:::::: The code at line 1235 was first introduced by commit
:::::: ef11291bcd5f963c72e7ba5952be3e3c97463d2c Add support the Korina (IDT RC32434) Ethernet MAC

:::::: TO: Florian Fainelli <florian.fainelli@telecomint.eu>
:::::: CC: Jeff Garzik <jeff@garzik.org>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-10-03  7:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202610030925.IEUthiBx-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=error27@gmail.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.