From: sashiko-bot@kernel.org
To: "Donggeun Yoo" <donggeunyoo.kernel@gmail.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] PCI/DOE: Fix double free of a duplicate feature's sysfs name
Date: Sat, 03 Oct 2026 10:29:06 +0000 [thread overview]
Message-ID: <20261003102907.7CFD51F0089B@smtp.kernel.org> (raw)
In-Reply-To: <20261003102221.59894-1-donggeunyoo.kernel@gmail.com>
> When a DOE feature is reported twice, sysfs_add_file_to_group() fails
> with -EEXIST for the second copy and pci_doe_sysfs_feature_populate()
> frees that attribute's name, but leaves the pointer in place.
> pci_doe_sysfs_feature_remove() frees every name again when the device
> is removed, or when a later feature fails to register, so the name is
> freed twice:
>
> BUG: KASAN: double-free in pci_doe_sysfs_feature_remove+0x117/0x1b0
> Call Trace:
> kfree+0x11a/0x420
> pci_doe_sysfs_feature_remove+0x117/0x1b0
> pci_doe_sysfs_teardown+0x90/0xf0
> pci_remove_bus_device+0x128/0x2e0
> pci_stop_and_remove_bus_device_locked+0x1d/0x30
> remove_store+0xd2/0xf0
>
> Clear the pointer after freeing the name.
>
> Fixes: 2311ab1820fe ("PCI/DOE: Expose DOE features via sysfs")
> Cc: stable@vger.kernel.org
> Suggested-by: Alistair Francis <alistair@alistair23.me>
> Assisted-by: LLM
> Signed-off-by: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261003102221.59894-1-donggeunyoo.kernel@gmail.com?part=1
next prev parent reply other threads:[~2026-10-03 10:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-03 10:22 [PATCH v2] PCI/DOE: Fix double free of a duplicate feature's sysfs name Donggeun Yoo
2026-10-03 10:29 ` sashiko-bot [this message]
2026-10-04 16:14 ` Jonathan Cameron
2026-10-05 16:20 ` Alistair
2026-10-05 23:21 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261003102907.7CFD51F0089B@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=donggeunyoo.kernel@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.