From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC5E14218AA for ; Sat, 3 Oct 2026 11:15:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791026129; cv=none; b=J5iELaB/69cfG5d2YjlTxh21vaVzX+qKemai6sneJRjv9pVdvIWv8q4iTfP3D/GJlMyRGXDXVpeKoOd4RfoV8kr2PZRaIDS8PJJKTbpQZlOkkO/wd6v4LvKY5/hqydxC6QuT051L8512uOxYvlII57XNdZI1uEO+iN4kJFHzsAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791026129; c=relaxed/simple; bh=X8S/38LYuheeYoO5Gbw8YYHsUED2ycWAmOg8/TJNhv0=; h=Date:From:To:Cc:Subject:Message-ID; b=AsZk3y8vAbWymLC/4I8Acv80p+WxNKnv0U25ph4SBKs5HB/6EWNQIEFxyVFr/EoRgoBlUx6sozSIEBHuMvFhiB14duebv01275we1sw9LTHpgbSTCdm7LZtZy9Fh3DynqqVfruqRI45tPJTXsARKNR1zrM8eubdJN6VcGxlm2GA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=OFTTsUt+; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OFTTsUt+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1791026128; x=1822562128; h=date:from:to:cc:subject:message-id; bh=X8S/38LYuheeYoO5Gbw8YYHsUED2ycWAmOg8/TJNhv0=; b=OFTTsUt+4EKyKKfvmCrhEwG1MeJj3m9CROFB92102eYJPG/tP4BNHK1Q fcALkHZjGC63Is/W8EXbrCTMfkW4lAAoI13P9kR0RJ109R9yqXNkr2Ykc ptXJzgyOLPBnOHGmx02Fj87nbB0+gRSDwG2iz8/DTi0LbKr85dyJdmF1j Tt4DOKYL2PGrEvGhbDkybZMmT4l10oAJf6xo3J4jNjGWO+MlPYWrtsc12 hCxsAfATGk1jmRmHIdP57qZlEwr+eKoQ0afhf0DlSMBVJt6TuQV3of7C/ mck3F48AvBQN/EHPMhqFLsKrbei2YG7n7pWiVE7do/bDP86v7ONiHIJ51 A==; X-CSE-ConnectionGUID: bQXncHOLRTqBjgrZ47v58w== X-CSE-MsgGUID: Z0k9lYGCT/2LnaC8Zf12lQ== X-IronPort-AV: E=McAfee;i="6800,10657,11923"; a="109260097" X-IronPort-AV: E=Sophos;i="6.27,138,1787036400"; d="scan'208";a="109260097" Received: from fmviesa013.fm.intel.com ([10.60.135.153]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2026 04:15:27 -0700 X-CSE-ConnectionGUID: FzOSjgKBQqKzXzF1clh+Wg== X-CSE-MsgGUID: Adtvkm5PSVGJ4li+wOorDg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,138,1787036400"; d="scan'208";a="420680" Received: from igk-lkp-server01.igk.intel.com (HELO 3fb566d470b1) ([10.211.93.152]) by fmviesa013.fm.intel.com with ESMTP; 03 Oct 2026 04:15:26 -0700 Received: from kbuild by 3fb566d470b1 with local (Exim 4.98.2) (envelope-from ) id 1xCxi5-0000000012R-3fV4; Sat, 03 Oct 2026 11:15:21 +0000 Date: Sat, 03 Oct 2026 13:14:55 +0200 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: [akpm-mm:mm-unstable 457/706] drivers/hid/hid-steam.c:557 steam_send_report_id() warn: check sign expansion for '__UNIQUE_ID_x__541' Message-ID: <202610031332.6ZaiErmO-lkp@intel.com> User-Agent: s-nail v14.9.25 Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Unfiltered warning: this smatch report is sent as-is and has not been reviewed for false positives, so please treat it with due skepticism. BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: David Hildenbrand CC: Andrew Morton CC: Linux Memory Management List CC: mm-commits@vger.kernel.org TO: "Lorenzo Stoakes (ARM)" CC: Andrew Morton CC: Linux Memory Management List tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable head: 33eb75fed9eef7a57e3f77c37c160d3e9ec55f2e commit: 1ff6d8554e97e41a8fd8b26da57f697f1417f616 [457/706] mm: add mmap action for discontiguous kernel page mapping :::::: branch date: 12 hours ago :::::: commit date: 12 hours ago config: x86_64-randconfig-2200-20261003 (https://download.01.org/0day-ci/archive/20261003/202610031332.6ZaiErmO-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 smatch: v0.5.0-9187-g5189e3fb If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202610031332.6ZaiErmO-lkp@intel.com/ smatch warnings: drivers/hid/hid-steam.c:557 steam_send_report_id() warn: check sign expansion for '__UNIQUE_ID_x__541' vim +/__UNIQUE_ID_x__541 +557 drivers/hid/hid-steam.c c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 516 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 517 static int steam_send_report_id(struct steam_device *steam, 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 518 u8 *cmd, int size, u8 report_id) c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 519 { c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 520 struct hid_report *r; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 521 u8 *buf; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 522 unsigned int retries = 50; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 523 int ret; 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 524 u32 len; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 525 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 526 r = steam->hdev->report_enum[HID_FEATURE_REPORT].report_id_hash[report_id]; cd11d1a6114bd4 Lee Jones 2022-07-08 527 if (!r) { 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 528 hid_err(steam->hdev, "No HID_FEATURE_REPORT present for ID %u\n", report_id); cd11d1a6114bd4 Lee Jones 2022-07-08 529 return -EINVAL; cd11d1a6114bd4 Lee Jones 2022-07-08 530 } cd11d1a6114bd4 Lee Jones 2022-07-08 531 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 532 len = hid_report_len(r); 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 533 if (len < 64) c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 534 return -EINVAL; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 535 c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 536 buf = hid_alloc_report_buf(r, GFP_KERNEL); c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 537 if (!buf) c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 538 return -ENOMEM; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 539 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 540 /* The report ID is always consistent */ 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 541 buf[0] = report_id; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 542 memcpy(buf + 1, cmd, size); c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 543 de435b770cd949 Vicki Pfau 2026-07-29 544 hid_dbg(steam->hdev, "Sending report %*ph\n", size, cmd); de435b770cd949 Vicki Pfau 2026-07-29 545 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 546 if (!(steam->quirks & STEAM_QUIRK_IBEX)) 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 547 len += 1; 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 548 c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 549 /* c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 550 * Sometimes the wireless controller fails with EPIPE c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 551 * when sending a feature report. 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 552 * Doing a HID_REQ_SET_REPORT and waiting for a while c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 553 * seems to fix that. c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 554 */ c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 555 do { 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 556 ret = hid_hw_raw_request(steam->hdev, report_id, 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 @557 buf, max(size + 1, len), c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 558 HID_FEATURE_REPORT, HID_REQ_SET_REPORT); c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 559 if (ret != -EPIPE) c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 560 break; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 561 msleep(20); c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 562 } while (--retries); c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 563 c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 564 kfree(buf); cfa66cba6d02ff Vicki Pfau 2026-08-11 565 /* cfa66cba6d02ff Vicki Pfau 2026-08-11 566 * Don't log if the failure is -ENODEV, as this cfa66cba6d02ff Vicki Pfau 2026-08-11 567 * can happen normally on disconnect. cfa66cba6d02ff Vicki Pfau 2026-08-11 568 */ cfa66cba6d02ff Vicki Pfau 2026-08-11 569 if (ret < 0 && ret != -ENODEV) c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 570 hid_err(steam->hdev, "%s: error %d (%*ph)\n", __func__, c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 571 ret, size, cmd); c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 572 return ret; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 573 } c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 574 :::::: The code at line 557 was first introduced by commit :::::: 0a80b4e8ec6a6e40937c7abdf8fb2ebe6cc7c1e5 HID: steam: Initial 2026 Steam Controller support :::::: TO: Vicki Pfau :::::: CC: Jiri Kosina -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki