From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3199ECA5FEC for ; Sat, 3 Oct 2026 17:57:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6991B10E984; Sat, 3 Oct 2026 17:57:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="FLtn1Iyk"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id C15A310E984 for ; Sat, 3 Oct 2026 17:57:05 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 4614E600CB; Sat, 3 Oct 2026 17:57:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17F5D1F0089B; Sat, 3 Oct 2026 17:57:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791050225; bh=g4yv4w+IQEE66nfDK6VQ322rv3viQPlezzmFOWCs+Yc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=FLtn1IykhxfI6UNeG0jKCeRlPIBad1zd2WT0Thvi2sWyauxm8OMquepIfCfzLsU5B PYRFzQdPhG28mxym2uh49IX4Bq9Zydrh7azxqj+Q0BPurYMo15rsE5Xl/fghLVhSqT +5XQnXtRSBcBCU6h5m/1FKZiH8K3uyuiDVVyZcYue9Xp3Alk3ghXeJmF0Uhu2KsdMr dxJTK1HT/9+OSB2UE9RPmpJvfGc8h7RUhYdWfF2XAb+7zyEFMxy2Baqq9aOnSLQa8J LL9Z0yG+BO3xJn2Z55PwC6dxDKAmhHEsEVXTXV8fs+c9pBDQdJ8/7YmAMiVhYRIM+B Ez7OkH5ieZvVQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 21/38] uprobes: remove VM_IO, set VM_MIXEDMAP for mapped kernel pages To: =?utf-8?b?TG9yZW56byBTdG9ha2VzIChBUk0p?= Cc: linux-scsi@vger.kernel.org, linux-s390@vger.kernel.org, "Oliver Upton" , "Christian Borntraeger" , linux-rdma@vger.kernel.org, linux-perf-users@vger.kernel.org, "Vasily Gorbik" , "Alexander Gordeev" , dri-devel@lists.freedesktop.org, "Heiko Carstens" , "Marc Zyngier" , selinux@vger.kernel.org, bpf@vger.kernel.org, kvm@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kvmarm@lists.linux.dev In-Reply-To: <20261003-b4-mmap-prepare-vma-flag-sanify-v4-21-a1f052500fd7@kernel.org> References: <20261003-b4-mmap-prepare-vma-flag-sanify-v4-0-a1f052500fd7@kernel.org> <20261003-b4-mmap-prepare-vma-flag-sanify-v4-21-a1f052500fd7@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 03 Oct 2026 17:57:02 +0000 Message-Id: <20261003175703.17F5D1F0089B@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > These are not MMIO pages so VMA_IO_BIT is an inappropriate flag to set. >=20 > Instead, set them VMA_MIXEDMAP_BIT as they are kernel mappings and this is > the appropriate flag to set for those. >=20 > This provides the semantics required - no VMA merging is permitted, but > does not prevent GUP. >=20 > However this has no meaningful impact as these are refcounted and thus can > be GUPed. >=20 > A previous commit already prevented __mm_populate() from being invoked on > XOL areas, which VMA_IO_BIT was previously relied upon to do, so that is = no > longer required. >=20 > Both VMAs set a VMA name, so always_dump_vma() returns true before > vma_dump_size() reaches its VMA_IO_BIT check, and thus there is no change > in core dump behaviour. >=20 > Change this for both the core xol_add_vma() function and the x86-specific > get_uprobe_trampoline() function. >=20 > Signed-off-by: Lorenzo Stoakes (ARM) Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261003-b4-mmap-pr= epare-vma-flag-sanify-v4-0-a1f052500fd7@kernel.org?part=3D21