Re: [PATCH 1/2] dt-bindings: bus: Add binding for Altera AXI Timeout Bridge

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
- [Medium] dt-bindings: invalid compatible string format altera-timeout-bridge
- [Medium] dt-bindings: erroneous required interrupt-parent breaks inheritance
- [Low] dt-bindings: example node name uses underscores instead of hyphens
- [Low] dt-bindings: unaligned 15-byte reg size in example
--

commit 2cd126fb35ab7ef8e7fe6463a8fed9d0a99d2108
Author: Vyacheslav Yurkov <V.Yurkov.EXT@bruker.com>

dt-bindings: bus: Add binding for Altera AXI Timeout Bridge

This commit adds a device tree binding for the Altera timeout bridge, which
connects an Avalon bus to the HPS and provides an address space for child
devices.

> diff --git a/Documentation/devicetree/bindings/bus/altera-timeout-bridge.yaml b/Documentation/devicetree/bindings/bus/altera-timeout-bridge.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/bus/altera-timeout-bridge.yaml
> @@ -0,0 +1,82 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/bus/altera-timeout-bridge.yaml#

[Severity: Medium]
Does this $id field inherit an incorrectly formatted prefix and missing comma
from the filename? The compatible string issues mentioned below seem to have
propagated to both the filename and this path reference.

[ ... ]

> +properties:
> +  compatible:
> +    items:
> +      - const: altera-timeout-bridge

[Severity: Medium]
Does this compatible string violate the standard device tree specification
that mandates the '<vendor>,<device>' format? The standard vendor prefix
for Altera is 'altr', not 'altera', and the missing comma separator breaks
standard pattern matching.

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - interrupt-parent

[Severity: Medium]
Should 'interrupt-parent' be explicitly required here? By explicitly listing
it as a required property, the schema mandates that every instantiated node
must define it. Does this violate standard Device Tree structural inheritance,
where interrupt routing is inherited from parent nodes?

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    intc: interrupt-controller {
> +        interrupt-controller;
> +        #interrupt-cells = <3>;
> +    };
> +
> +    timeout_bridge_hps@10000 {

[Severity: Low]
This isn't a functional bug, but the example node name uses underscores
instead of hyphens. Could this trigger dtc W=1 warnings by violating standard
Device Tree naming conventions?

> +        compatible = "altera-timeout-bridge", "simple-bus";
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +
> +        reg = <0x10000 0xF>;

[Severity: Low]
Is this 15-byte window size intentional? MMIO regions are universally aligned
to word (4-byte) boundaries, meaning a 15-byte window truncates the final
32-bit register space (ending at 15 instead of 16). Could this be a typo
for 0x10?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261003-feature-timeout-ip-v1-0-8837c311d571@bruker.com?part=1