Re: [PATCH v5 2/3] platform/arm64: add Lenovo Yoga Slim 7x Gen 11 EC driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] hwmon: hardware monitoring registration outside drivers/hwmon/
--

commit 1e4db7708b954def668e65b4325f61905437ade8
Author: Oleg Keri <okerixx@gmail.com>

platform/arm64: add Lenovo Yoga Slim 7x Gen 11 EC driver

This commit introduces a new embedded controller driver for the Lenovo Yoga 
Slim 7x Gen 11. It exposes board thermistors and CPU fan speed through the 
hardware monitoring subsystem, as well as a keyboard backlight via the LED 
subsystem.

> diff --git a/drivers/platform/arm64/lenovo-yoga-slim7x-gen11-ec.c b/drivers/platform/arm64/lenovo-yoga-slim7x-gen11-ec.c
> new file mode 100644
> index 0000000000000..1ef11b9eeffab
> --- /dev/null
> +++ b/drivers/platform/arm64/lenovo-yoga-slim7x-gen11-ec.c
[ ... ]
> +static int slim7x11_ec_probe(struct i2c_client *client)
> +{
[ ... ]
> +	if (!ec->temp_present) {
> +		return dev_err_probe(dev, -ENODEV,
> +				     "no thermistor reported a usable value\n");
> +	}
> +
> +	dev_dbg(dev, "thermistors present: %#lx\n", ec->temp_present);
> +
> +	hwmon = devm_hwmon_device_register_with_info(dev, "yoga_slim7x_ec", ec,
> +						     &slim7x11_ec_chip_info, NULL);

[Severity: Low]
Does this hardware monitoring registration bypass the hwmon subsystem 
architectural layering rules? 

According to the hwmon subsystem guidelines, hardware monitoring devices 
should reside in the drivers/hwmon/ directory. If a device has secondary 
functionality or its main functionality isn't hardware monitoring, the hwmon 
features should be implemented as an auxiliary device driver, and that driver 
should reside in drivers/hwmon/.

Registering the hwmon device directly from drivers/platform/arm64/ increases 
driver complexity and bypasses hwmon maintainer review.

> +	if (IS_ERR(hwmon))
> +		return PTR_ERR(hwmon);
> +
> +	ec->kbd_led.name = "platform::kbd_backlight";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261003202143.4697-1-okerixx@gmail.com?part=2