From: Ido Schimmel <idosch@nvidia.com>
To: Sang-Hoon Choi <csh0052@gmail.com>
Cc: Petr Machata <petrm@nvidia.com>,
netdev@vger.kernel.org, Jiri Pirko <jiri@resnulli.us>,
Changyul Lee <lcy8047@gmail.com>
Subject: Re: [PATCH net] mlxsw: spectrum_router: destroy FIB hash table on bind failure
Date: Sun, 4 Oct 2026 10:47:54 +0300 [thread overview]
Message-ID: <20261004074754.GA89916@shredder> (raw)
In-Reply-To: <20261003.final104.6f67a6ed1c4476b7@gmail.com>
On Fri, Oct 02, 2026 at 07:47:40PM +0000, Sang-Hoon Choi wrote:
> mlxsw_sp_fib_create() initializes fib->ht before binding the LPM tree.
> If the bind fails, the error path releases the tree and frees fib without
> destroying the initialized hash table, leaking its bucket allocation.
>
> Destroy fib->ht on the post-initialization failure path.
>
> Fixes: 2b52ce02e1d1 ("mlxsw: spectrum_router: Remove unnecessary prefix lengths from LPM tree")
> Reported-by: Changyul Lee <lcy8047@gmail.com>
> Assisted-by: LLM
> Signed-off-by: Sang-Hoon Choi <csh0052@gmail.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2026-10-04 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 19:47 [PATCH net] mlxsw: spectrum_router: destroy FIB hash table on bind failure Sang-Hoon Choi
2026-10-03 10:00 ` Ivan Vecera
2026-10-04 7:47 ` Ido Schimmel [this message]
2026-10-06 0:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261004074754.GA89916@shredder \
--to=idosch@nvidia.com \
--cc=csh0052@gmail.com \
--cc=jiri@resnulli.us \
--cc=lcy8047@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.