Re: [PATCH net] Revert "net/mlx5: E-Switch, preserve max tx speed on vport state modification"

[sashiko-bot@kernel.org]

> From: Or Har-Toov <ohartoov@nvidia.com>
> 
> This reverts commit ad0ae7aefa7a ("net/mlx5: E-Switch, preserve max tx
> speed on vport state modification").
> 
> mlx5_modify_vport_admin_state() and mlx5_esw_adj_vport_modify() query
> the vport's current max_tx_speed before modifying its state, and
> write that value back, to avoid resetting it to 0 as a side effect
> of an unrelated admin-state change.
> 
> That's unnecessary: max_tx_speed is optional in MODIFY_VPORT_STATE -
> FW skips writing it whenever it's 0, treating that as "not provided"
> rather than "reset to zero". Leaving it unset already preserves FW's
> current value, with no query needed.
> 
> Fixes: ad0ae7aefa7a ("net/mlx5: E-Switch, preserve max tx speed on vport state modification")
> Signed-off-by: Or Har-Toov <ohartoov@nvidia.com>
> Reviewed-by: Mark Bloch <mbloch@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261004083531.216988-1-tariqt@nvidia.com?part=1