Re: [PATCH v6 3/9] serial: max310x: centralize the RS485 transceiver programming

[sashiko-bot@kernel.org]

> The HDPIXDELAY RTS delays and the MODE1 auto-transceiver enable are
> programmed in three places - the rs485-config worker, startup() and
> break_ctl()'s break-off restore - each with its own copy of the
> register sequence. Move the sequence into a helper,
> max310x_set_rts_ctl_params(), together with the tx_break guard that
> keeps the MODE1 write away from a break in progress; the break-off
> restore reapplies the current configuration through the same helper.
> 
> No functional change intended. The copies differed only in that
> startup() clamped the delays to the 4-bit field while the worker wrote
> them unclamped; the helper clamps, and the difference is unreachable
> while rs485_config() still rejects delays above 15 ms with -ERANGE.
> Break-off additionally rewrites HDPIXDELAY with the values it already
> holds, a no-op on the wire.
> 
> Assisted-by: Claude:claude-fable-5
> Signed-off-by: Tapio Reijonen <tapio.reijonen@vaisala.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261004-max310x-rs485-sw-delay-v6-0-3a0ef13ed9e3@vaisala.com?part=3