Re: [PATCH 2/2] dt-bindings: i2c: rtl9300: add pinctrl

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] dt-bindings: ABI breakage by making pinctrl required for rtl9607-i2c
--

commit b162c61d2fc7ab941d4ea49cc274452fca8d089d
Author: Michael Zavertkin <misha.zavertkin@mail.ru>

dt-bindings: i2c: rtl9300: add pinctrl

For RTL9607C driver used to configure IO_MODE register. This register is
global and is a scope of pinctrl driver (either pinctrl-single or WIP
driver for SoC). Drop realtek,scl requirement for that SoC and require
pinctrl instead.

> diff --git a/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml b/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml
> index 5873cfdc5b3e0..ad143509aa425 100644
> --- a/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml
[ ... ]
> @@ -94,8 +98,9 @@ allOf:
>              const: realtek,rtl9607-i2c
>      then:
>        required:
> -        - realtek,scl
>          - clocks
> +        - pinctrl-0
> +        - pinctrl-names

[Severity: Critical]
Does making these properties strictly required introduce a regression for
existing device trees?

Device tree bindings are considered stable ABI, and changes must be backward
compatible. The realtek,rtl9607-i2c compatible string was already present in
the bindings. Existing valid device trees for this SoC do not contain
pinctrl-0 or pinctrl-names because the previous schema used
additionalProperties: false without defining them.

Adding pinctrl-0 and pinctrl-names to the required list in the allOf block
for rtl9607-i2c means all existing, deployed device trees will now fail
schema validation during dtbs_check.

Could these new properties be made optional to prevent ABI breakage?

>  
>  required:
>    - compatible

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1791127538.git.misha.zavertkin@mail.ru?part=2