From: sashiko-bot@kernel.org
To: "Svyatoslav Ryhel" <clamor95@gmail.com>
Cc: lee@kernel.org, devicetree@vger.kernel.org, robh@kernel.org,
conor+dt@kernel.org, mfd@lists.linux.dev
Subject: Re: [PATCH v2 1/3] regulator: dt-bindings: maxim,max8907: Convert to DT schema
Date: Sun, 04 Oct 2026 16:54:29 +0000 [thread overview]
Message-ID: <20261004165429.AC8441F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261004164540.198446-2-clamor95@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: broken schema reference to non-existent nvidia,tegra-regulators-coupling.yaml
--
commit 299fcba3d236bda6f3824120d17a27592c67f650
Author: Svyatoslav Ryhel <clamor95@gmail.com>
regulator: dt-bindings: maxim,max8907: Convert to DT schema
Convert Maxim MAX8907 regulator binding from text to DT schema. Reference
to nvidia,tegra-regulators-coupling in child regulator nodes.
> diff --git a/Documentation/devicetree/bindings/regulator/maxim,max8907.yaml b/Documentation/devicetree/bindings/regulator/maxim,max8907.yaml
> new file mode 100644
> index 0000000000000..e4e1390a49b9b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/maxim,max8907.yaml
[ ... ]
> + regulators:
> + type: object
> + additionalProperties: false
> +
> + patternProperties:
> + "^(sd[1-3]|ldo([1-9]|1[0-9]|20)|bbat|mbatt|out(5v|33v)|sdby|vrtc)$":
> + allOf:
> + - $ref: /schemas/regulator/regulator.yaml#
> + - $ref: /schemas/regulator/nvidia,tegra-regulators-coupling.yaml#
[Severity: Low]
Does this schema reference break dtschema device tree validation?
The dt_binding_check validation tool will fail because it cannot resolve the
referenced nvidia,tegra-regulators-coupling.yaml schema, as the target file
has not been converted and still only exists as a .txt binding.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261004164540.198446-1-clamor95@gmail.com?part=1
next prev parent reply other threads:[~2026-10-04 16:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 16:45 [PATCH v2 0/3] mfd: max8907: Schema, pdata and poweroff Svyatoslav Ryhel
2026-10-04 16:45 ` [PATCH v2 1/3] regulator: dt-bindings: maxim,max8907: Convert to DT schema Svyatoslav Ryhel
2026-10-04 16:54 ` sashiko-bot [this message]
2026-10-05 13:30 ` Rob Herring (Arm)
2026-10-04 16:45 ` [PATCH v2 2/3] mfd: max8907: Remove platform_data based probing Svyatoslav Ryhel
2026-10-04 16:51 ` sashiko-bot
2026-10-04 16:45 ` [PATCH v2 3/3] mfd: max8907: Convert to use device managed poweroff handler Svyatoslav Ryhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261004165429.AC8441F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.