Re: [PATCH v2] dt-bindings: gpio: pca95xx: add onnn,pca9655 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: commit message falsely claims in-tree DTS usage
--

commit 7b4c1f570780f70afdcc949de9998c051c2323e5
Author: Rosen Penev <rosenp@gmail.com>

dt-bindings: gpio: pca95xx: add onnn,pca9655 compatible

This commit documents the onnn,pca9655 compatible string for the On Semi 
variant of the pca9555 16-bit I2C GPIO expander. It adds the string alongside 
other standalone entries without a fallback.

Closes: https://lore.kernel.org/oe-kbuild-all/202610021617.AlVUa9No-lkp@intel.com/

> The pca9655 is the On Semi variant of the pca9555 16-bit I2C GPIO
> expander. "onnn,pca9655" is already used standalone by in-tree DTS
> (armada-388-clearfog, armada-388-helios4) and has a dedicated entry in
> the pca953x driver's OF match table, but was never documented, causing
> dtbs_check failures.

[Severity: Medium]
Is this claim about in-tree DTS usage accurate? 

Looking at the armada-388-clearfog.dtsi file, the compatible string appears
to be only used within a comment:

        /*
         * This is how it should be:
         * compatible = "onnn,pca9655", "nxp,pca9555";
         * but you can't do this because of the way I2C works.
         */
        compatible = "nxp,pca9555";

Because the string is only present in a comment and the active property is
nxp,pca9555, it would not trigger dtbs_check failures. Could the commit
message be updated to reflect why the binding actually needs to be added?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261004191042.143713-1-rosenp@gmail.com?part=1