Re: [PATCH v3] rtc: stmp3xxx: use devm_platform_ioremap_resource()

[sashiko-bot@kernel.org]

> Replace the open-coded platform_get_resource() plus devm_ioremap()
> sequence with a single devm_platform_ioremap_resource() call, which folds
> the resource lookup and mapping into one step and returns an ERR_PTR on
> failure, checked with IS_ERR() and propagated via PTR_ERR().
> 
> Move the mapping ahead of the devm_kzalloc() so that an error or deferred
> probe is handled before the rtc_data allocation, avoiding needless work.
> 
> The fsl,stmp3xxx-rtc nodes in imx23.dtsi (reg = <0x8005c000 0x2000>) and
> imx28.dtsi (reg = <0x80056000 0x2000>) each provide a single
> non-overlapping IORESOURCE_MEM window, so the region reservation now
> performed by devm_platform_ioremap_resource() introduces no conflict.
> 
> Keep the alarm IRQ in a local, as it is only used in probe, and fail
> probe on a platform_get_irq() error instead of passing it to
> devm_request_irq(). Drop the open-coded error messages, as
> devm_platform_ioremap_resource() and devm_request_irq() already
> report failures.
> 
> Assisted-by: LLM
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261004221327.416323-1-rosenp@gmail.com?part=1