Re: [PATCH v6 1/5] KVM: PPC: selftests: add support for powerpc

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] selftests: build failure due to undeclared memory allocation functions
--

commit 504c1ed58b27eced07a127f9dbb77eee82c18970
Author: Nicholas Piggin <npiggin@gmail.com>
Subject: KVM: PPC: selftests: add support for powerpc

This commit implements KVM selftests support for powerpc (Book3S-64).
However, it introduces build failures because of calls to undeclared
memory allocation functions.

Link: https://lore.kernel.org/linuxppc-dev/cover.1781093720.git.ritesh.list@gmail.com/

> diff --git a/tools/testing/selftests/kvm/lib/powerpc/processor.c b/tools/testing/selftests/kvm/lib/powerpc/processor.c
> new file mode 100644
> index 0000000000000..301455024571e
> --- /dev/null
> +++ b/tools/testing/selftests/kvm/lib/powerpc/processor.c
> @@ -0,0 +1,512 @@
> [ ... ]
> +void virt_arch_pgd_alloc(struct kvm_vm *vm)
> +{
> [ ... ]
> +	pgd_pages = (1UL << (RADIX_PGD_INDEX_SIZE + 3)) >> vm->page_shift;
> +	if (!pgd_pages)
> +		pgd_pages = 1;
> +	pgtb = vm_alloc_page_table_pages(vm, pgd_pages);

[Severity: Low]
Is the definition of vm_alloc_page_table_pages missing? This causes
the module to fail compiling and linking because the function is
undefined.

> +	vm->mmu.pgd = pgtb;
> [ ... ]
> +static gpa_t __vm_alloc_pt(struct kvm_vm *vm, u64 pt_shift)
> +{
> +	gpa_t pt;
> +
> +	if (pt_shift >= vm->page_shift) {
> +		size_t pt_pages = 1ULL << (pt_shift - vm->page_shift);
> +
> +		pt = vm_alloc_page_table_pages(vm, pt_pages);

[Severity: Low]
Does this code also rely on the undefined vm_alloc_page_table_pages
function?

> +	} else {
> [ ... ]
> +void kvm_arch_vm_post_create(struct kvm_vm *vm, unsigned int nr_vcpus)
> +{
> +	size_t excp_size = __interrupts_end - __interrupts_start;
> +	size_t excp_pages = (excp_size + vm->page_size - 1) / vm->page_size;
> +	gpa_t excp_paddr;
> +	void *mem;
> +
> +	/*
> +	 * Guest interrupts are taken in real-mode, i.e. the vectors must live
> +	 * at gPA 0.  Use the innermost allocator to override the minimum GPA
> +	 * that MEM_REGION_DATA would otherwise impose.
> +	 */
> +	excp_paddr = ____vm_phy_pages_alloc(vm, excp_pages, 0,
> +					    vm->memslots[MEM_REGION_DATA],
> +					    vm_arch_has_protected_memory(vm),
> +					    false);

[Severity: Low]
Could this call to an undeclared function ____vm_phy_pages_alloc be a
mistake? This call passes 6 arguments, which differs from the standard
5 arguments.

> +
> +	TEST_ASSERT(excp_paddr == 0,

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1791014923.git.ritesh.list@gmail.com?part=1