[LTP] [PATCH] pathconf01: Allow EINVAL where POSIX leaves support unspecified

[Wake Liu via ltp <ltp@lists.linux.it>]

POSIX lists two EINVAL cases for pathconf(). It shall fail with EINVAL
when the value of name is not valid. It may also fail with EINVAL when
"the implementation does not support an association of the variable
name with the specified file".

The test always calls pathconf() on a directory. For a directory, POSIX
leaves it unspecified whether _PC_MAX_CANON, _PC_MAX_INPUT and
_PC_VDISABLE (note 2), _PC_ASYNC_IO, _PC_PRIO_IO and _PC_SYNC_IO
(note 8) and the _PC_REC_* names (note 10) are supported, so EINVAL is
allowed for them.

Bionic before Android 15 returns -1 and sets errno to EINVAL for
_PC_REC_INCR_XFER_SIZE and _PC_REC_MAX_XFER_SIZE, which makes the test
fail.

Report EINVAL as TCONF for these names. EINVAL for the other names is
still a failure.

Also print the name and errno on failure, so it is clear which name
failed.

Signed-off-by: Wake Liu <wakel@google.com>
---
 .../kernel/syscalls/pathconf/pathconf01.c     | 36 ++++++++++++-------
 1 file changed, 23 insertions(+), 13 deletions(-)

diff --git a/testcases/kernel/syscalls/pathconf/pathconf01.c b/testcases/kernel/syscalls/pathconf/pathconf01.c
index 5af45e417..635c356bc 100644
--- a/testcases/kernel/syscalls/pathconf/pathconf01.c
+++ b/testcases/kernel/syscalls/pathconf/pathconf01.c
@@ -19,24 +19,26 @@ static char *path;
 static struct tcase {
 	int value;
 	char *name;
+	/* POSIX leaves support for a directory unspecified */
+	int einval_ok;
 } tcases[] = {
 	{NAME_DESC(_PC_LINK_MAX)},
-	{NAME_DESC(_PC_MAX_CANON)},
-	{NAME_DESC(_PC_MAX_INPUT)},
+	{NAME_DESC(_PC_MAX_CANON), .einval_ok = 1},
+	{NAME_DESC(_PC_MAX_INPUT), .einval_ok = 1},
 	{NAME_DESC(_PC_NAME_MAX)},
 	{NAME_DESC(_PC_PATH_MAX)},
 	{NAME_DESC(_PC_PIPE_BUF)},
 	{NAME_DESC(_PC_CHOWN_RESTRICTED)},
 	{NAME_DESC(_PC_NO_TRUNC)},
-	{NAME_DESC(_PC_VDISABLE)},
-	{NAME_DESC(_PC_SYNC_IO)},
-	{NAME_DESC(_PC_ASYNC_IO)},
-	{NAME_DESC(_PC_PRIO_IO)},
+	{NAME_DESC(_PC_VDISABLE), .einval_ok = 1},
+	{NAME_DESC(_PC_SYNC_IO), .einval_ok = 1},
+	{NAME_DESC(_PC_ASYNC_IO), .einval_ok = 1},
+	{NAME_DESC(_PC_PRIO_IO), .einval_ok = 1},
 	{NAME_DESC(_PC_FILESIZEBITS)},
-	{NAME_DESC(_PC_REC_INCR_XFER_SIZE)},
-	{NAME_DESC(_PC_REC_MAX_XFER_SIZE)},
-	{NAME_DESC(_PC_REC_MIN_XFER_SIZE)},
-	{NAME_DESC(_PC_REC_XFER_ALIGN)},
+	{NAME_DESC(_PC_REC_INCR_XFER_SIZE), .einval_ok = 1},
+	{NAME_DESC(_PC_REC_MAX_XFER_SIZE), .einval_ok = 1},
+	{NAME_DESC(_PC_REC_MIN_XFER_SIZE), .einval_ok = 1},
+	{NAME_DESC(_PC_REC_XFER_ALIGN), .einval_ok = 1},
 };
 
 static void verify_pathconf(unsigned int i)
@@ -47,10 +49,18 @@ static void verify_pathconf(unsigned int i)
 
 	TEST(pathconf(path, tc->value));
 
-	if (TST_RET == -1 && errno != 0)
-		tst_res(TFAIL, "pathconf Failed, errno = %d", TST_ERR);
-	else
+	if (TST_RET != -1 || !TST_ERR) {
 		tst_res(TPASS, "pathconf(%s, %s)", path, tc->name);
+		return;
+	}
+
+	if (tc->einval_ok && TST_ERR == EINVAL) {
+		tst_res(TCONF, "pathconf(%s, %s) not supported for a directory",
+			path, tc->name);
+		return;
+	}
+
+	tst_res(TFAIL | TTERRNO, "pathconf(%s, %s)", path, tc->name);
 }
 
 static struct tst_test test = {
-- 
2.56.0.rc1.315.gc6ed9934b7-goog


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp