Re: [PATCH net] net/sched: cls_bpf: accept dev-bound programs on shared blocks

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] bpf: multi-line comment style violation in cls_bpf.c
--

commit 335af23f9a1d13cab5f84cecaf4fd5a4dda63d7f
Author: Jamal Hadi Salim <jhs@mojatatu.com>

net/sched: cls_bpf: accept dev-bound programs on shared blocks

This commit allows device-bound programs to be attached through shared blocks
by ensuring the program matches every netdev bound to the block. Prior to
this, attaching to a shared block would incorrectly return -EINVAL because the
block's qdisc is NULL.

Link: https://lore.kernel.org/netdev/20260809094418.901607-1-jhs@mojatatu.com/

> diff --git a/net/sched/cls_bpf.c b/net/sched/cls_bpf.c
> index 188cf0f949dd4..6a54f8a7b8218 100644
> --- a/net/sched/cls_bpf.c
> +++ b/net/sched/cls_bpf.c
> @@ -392,9 +392,29 @@ static int cls_bpf_prog_from_efd(struct nlattr **tb, struct cls_bpf_prog *prog,
>  	if (bpf_prog_is_dev_bound(fp->aux)) {
>  		struct tcf_block *block = tp->chain->block;
>  		struct net_device *dev;
> -
> -		dev = block->q ? qdisc_dev(block->q) : NULL;
> -		if (!dev || !bpf_offload_dev_match(fp, dev)) {
> +		unsigned long ifindex;
> +		bool found = false;
> +		bool match = false;
> +
> +		/* A shared block has no qdisc (block->q == NULL) but may
> +		 * bind several netdevs; the program is offloaded to all of
> +		 * them, so it must match all of them.
> +		 */

[Severity: Low]
This isn't a bug, but does this multi-line comment follow the documented BPF
subsystem coding style? The BPF subsystem expects the opening "/*" to be on
its own line, rather than having text on the same line as the opening.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/QDISC-PYC7.v1.20261003103747@mojatatu.com?part=1