All of lore.kernel.org
 help / color / mirror / Atom feed
From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Trevor Wu <trevor.wu@mediatek.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	cassiogabrielcontato@gmail.com,
	Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>,
	Liviu Dudau <liviu.dudau@arm.com>,
	Haotian Zhang <vulab@iscas.ac.cn>,
	HariKrishna Sagala <hariconscious@gmail.com>,
	linux-sound@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH v2 08/14] ASoC: mediatek: mt8195: Remove redundant error message
Date: Mon,  5 Oct 2026 18:02:51 +0700	[thread overview]
Message-ID: <20261005110257.50145-9-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20261005110257.50145-1-phucduc.bui@gmail.com>

From: bui duc phuc <phucduc.bui@gmail.com>

The errors handled here are already reported by the called functions,
either directly or deeper in the call chain. Therefore, the additional
dev_warn() and dev_err_probe() call is redundant and can be removed.

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
 sound/soc/mediatek/mt8195/mt8195-afe-pcm.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c b/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c
index bb357cc674cb..1bca2f62e76e 100644
--- a/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c
+++ b/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c
@@ -3083,7 +3083,7 @@ static int mt8195_afe_pcm_dev_probe(struct platform_device *pdev)
 	/* initial audio related clock */
 	ret = mt8195_afe_init_clock(afe);
 	if (ret)
-		return dev_err_probe(dev, ret, "init clock error\n");
+		return ret;
 
 	/* reset controller to reset audio regs before regmap cache */
 	rstc = devm_reset_control_get_exclusive(dev, "audiosys");
@@ -3130,7 +3130,7 @@ static int mt8195_afe_pcm_dev_probe(struct platform_device *pdev)
 	ret = devm_request_irq(dev, irq_id, mt8195_afe_irq_handler,
 			       IRQF_TRIGGER_NONE, "asys-isr", (void *)afe);
 	if (ret)
-		return dev_err_probe(dev, ret, "could not request_irq for asys-isr\n");
+		return ret;
 
 	/* init sub_dais */
 	INIT_LIST_HEAD(&afe->sub_dais);
@@ -3188,10 +3188,9 @@ static int mt8195_afe_pcm_dev_probe(struct platform_device *pdev)
 	/* register component */
 	ret = devm_snd_soc_register_component(dev, &mtk_afe_pcm_platform,
 					      afe->dai_drivers, afe->num_dai_drivers);
-	if (ret) {
-		dev_warn(dev, "err_platform\n");
+	if (ret)
 		goto err_pm_put;
-	}
+
 
 	ret = regmap_multi_reg_write(afe->regmap, mt8195_afe_reg_defaults,
 				     ARRAY_SIZE(mt8195_afe_reg_defaults));
-- 
2.43.0



  parent reply	other threads:[~2026-10-05 11:03 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 11:02 [PATCH v2 00/14] ASoC: mediatek: mt8195: Fix clock error handling phucduc.bui
2026-10-05 11:02 ` [PATCH v2 01/14] ASoC: mediatek: mt8195: Fix tuner " phucduc.bui
2026-10-08 11:21   ` Ajay Kumar Nandam
2026-10-09  7:03     ` Bui Duc Phuc
2026-10-05 11:02 ` [PATCH v2 02/14] ASoC: mediatek: mt8195: Use dev_err_probe() in mt8195_afe_init_clock() phucduc.bui
2026-10-08 11:23   ` Ajay Kumar Nandam
2026-10-05 11:02 ` [PATCH v2 03/14] ASoC: mediatek: mt8195: Fix register access clock error handling phucduc.bui
2026-10-08 11:25   ` Ajay Kumar Nandam
2026-10-05 11:02 ` [PATCH v2 04/14] ASoC: mediatek: mt8195: Fix timing system " phucduc.bui
2026-10-05 11:02 ` [PATCH v2 05/14] ASoC: mediatek: mt8195: Fix paired memif " phucduc.bui
2026-10-08 11:42   ` Ajay Kumar Nandam
2026-10-09  7:11     ` Bui Duc Phuc
2026-10-05 11:02 ` [PATCH v2 06/14] ASoC: mediatek: mt8195: Fix FE startup " phucduc.bui
2026-10-05 11:02 ` [PATCH v2 07/14] ASoC: mediatek: mt8195: Fix runtime resume " phucduc.bui
2026-10-05 11:02 ` phucduc.bui [this message]
2026-10-08 11:48   ` [PATCH v2 08/14] ASoC: mediatek: mt8195: Remove redundant error message Ajay Kumar Nandam
2026-10-05 11:02 ` [PATCH v2 09/14] ASoC: mediatek: mt8195: Propagate IRQ lookup errors phucduc.bui
2026-10-08 11:50   ` Ajay Kumar Nandam
2026-10-05 11:02 ` [PATCH v2 10/14] ASoC: mediatek: mt8195: Fix ETDM MCLK error handling phucduc.bui
2026-10-08 11:54   ` Ajay Kumar Nandam
2026-10-05 11:02 ` [PATCH v2 11/14] ASoC: mediatek: mt8195: Fix ETDM startup " phucduc.bui
2026-10-08 11:55   ` Ajay Kumar Nandam
2026-10-05 11:02 ` [PATCH v2 12/14] ASoC: mediatek: mt8195: Fix HDMI TX " phucduc.bui
2026-10-05 11:02 ` [PATCH v2 13/14] ASoC: mediatek: mt8195: Fix ETDM probe " phucduc.bui
2026-10-05 11:02 ` [PATCH v2 14/14] ASoC: mediatek: mt8195: Fix clock parent " phucduc.bui
2026-10-08 12:03   ` Ajay Kumar Nandam
2026-10-09  7:21     ` Bui Duc Phuc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261005110257.50145-9-phucduc.bui@gmail.com \
    --to=phucduc.bui@gmail.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=broonie@kernel.org \
    --cc=cassiogabrielcontato@gmail.com \
    --cc=hariconscious@gmail.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mukesh.ojha@oss.qualcomm.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=trevor.wu@mediatek.com \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.