All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Fleischmann <sfle@kth.se>
To: Michael Chan <michael.chan@broadcom.com>,
	Eric Dumazet <edumazet@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	netdev@vger.kernel.org, stable@vger.kernel.org,
	Eric Dumazet <edumazet@google.com>,
	Pavan Chebbi <pavan.chebbi@broadcom.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>
Subject: Re: [PATCH net] bnxt_en: fix DMA mapping length for padded small packets
Date: Mon, 5 Oct 2026 11:49:05 +0200	[thread overview]
Message-ID: <20261005114905.36ec94eb@nargothrond> (raw)
In-Reply-To: <CACKFLi=ja544ms39JMwaAdiyKzzDAUFxSFUWETh6kfzQmcj4dg@mail.gmail.com>

On Sun, 4 Oct 2026 21:14:31 -0700
Michael Chan <michael.chan@broadcom.com> wrote:

> On Sun, Oct 4, 2026 at 7:38 PM Eric Dumazet <edumazet@kernel.org>
> wrote:
> 
> > This issue was exposed after commit 447cbe95ebb9 ("vlan: fix
> > skb_under_panic and races when toggling HW VLAN offload") because
> > reserving extra VLAN headroom rounded LL_RESERVED_SPACE from 48 up
> > to 64 bytes, shifting skb->data offsets and potentially causing
> > small frames to land right against page boundaries.
> >
> > Fix this by using skb_put_padto(skb, BNXT_MIN_PKT_SIZE) in the
> > normal_tx path. This ensures skb->len and skb_headlen(skb) reflect
> > the padded size so that dma_map_single() maps the full buffer and
> > the descriptor length is consistent. This also removes the
> > temporary 'pad' variable and masking logic.
> >
> > Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
> > Cc: stable@vger.kernel.org
> > Reported-by: Stefan Fleischmann <sfle@kth.se>
> > Closes:
> > https://lore.kernel.org/netdev/20261004122616.56714cbd@nargothrond/
> > Signed-off-by: Eric Dumazet <edumazet@google.com>  
> 
> Thanks.
> Reviewed-by: Michael Chan <michael.chan@broadcom.com>

Thanks a lot! I am testing the patch right now on 6.18.55. The system
is already up for two hours without issues. Before the patch I couldn't
get past 45 minutes without hitting the IOMMU DMA read fault.

Best,
Stefan

  reply	other threads:[~2026-10-05  9:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05  2:38 [PATCH net] bnxt_en: fix DMA mapping length for padded small packets Eric Dumazet
2026-10-05  4:14 ` Michael Chan
2026-10-05  9:49   ` Stefan Fleischmann [this message]
2026-10-05 11:18 ` Salvatore Bonaccorso
2026-10-05 14:26   ` Bernhard Schmidt
2026-10-07  6:51     ` Fabian Grünbichler
2026-10-05 21:16 ` netdev-bot+sashiko
2026-10-06  3:56   ` Eric Dumazet
2026-10-06  3:59     ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261005114905.36ec94eb@nargothrond \
    --to=sfle@kth.se \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavan.chebbi@broadcom.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.