From: sashiko-bot@kernel.org
To: "Thomas Zimmermann" <tzimmermann@suse.de>
Cc: linux-serial@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v4 3/5] vgacon: Use vt_cursor_{start,end}()
Date: Mon, 05 Oct 2026 13:38:54 +0000 [thread overview]
Message-ID: <20261005133854.6B3D61F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261005133335.344302-4-tzimmermann@suse.de>
> Replace vgacon's custom cursor metrics with the shared helpers
> vc_cursor_start() and vc_font_cursor_end(). Note that the _end()
> function returns the index of the scanline below the cursor, while
> VGA hardware expects the cursor's final scanline. Hence vgacon
> subtracts 1 from the end value.
>
> The cursor shapes remain mostly unchanged, except that non-underline
> cursors now also use the glyph's top-most and bottom-most scanline.
> This follows the style used by fbcon.
>
> v4:
> - disable if CUR_DEF maps to CUR_NONE
> v2:
> - restore use of vc_cell_height (Sashiko)
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261005133335.344302-1-tzimmermann@suse.de?part=3
next prev parent reply other threads:[~2026-10-05 13:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 13:30 [PATCH v4 0/5] fbcon,vgacon,vt: Share helpers for text cursors Thomas Zimmermann
2026-10-05 13:30 ` [PATCH v4 1/5] vt: Add cursor-size helpers Thomas Zimmermann
2026-10-05 13:39 ` sashiko-bot
2026-10-05 13:31 ` [PATCH v4 2/5] vgacon: Remove trailing whitespaces Thomas Zimmermann
2026-10-05 13:35 ` sashiko-bot
2026-10-05 13:31 ` [PATCH v4 3/5] vgacon: Use vt_cursor_{start,end}() Thomas Zimmermann
2026-10-05 13:38 ` sashiko-bot [this message]
2026-10-05 13:31 ` [PATCH v4 4/5] lib/fonts: Add font_glyph_cursor() helper Thomas Zimmermann
2026-10-05 13:40 ` sashiko-bot
2026-10-05 13:31 ` [PATCH v4 5/5] fbcon: Replace fbcon_fill_cursor_mask() with fbcon_cursor_glyph() Thomas Zimmermann
2026-10-05 13:39 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261005133854.6B3D61F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.