From: Stephen Hemminger <stephen@networkplumber.org>
To: Manish Kurup <manish.kurup@broadcom.com>
Cc: dev@dpdk.org, kishore.padmanabha@broadcom.com, stable@dpdk.org
Subject: Re: [PATCH] net/bnxt: fix hash seeding and hot-upgrade lock handling
Date: Mon, 5 Oct 2026 14:05:06 -0700 [thread overview]
Message-ID: <20261005140506.325710d7@phoenix.local> (raw)
In-Reply-To: <20261005202519.17873-1-manish.kurup@broadcom.com>
On Mon, 5 Oct 2026 15:25:19 -0500
Manish Kurup <manish.kurup@broadcom.com> wrote:
> +
> + /* Random per-table seed so the CRC hash cannot be predicted offline
> + * from attacker-controlled flow match fields.
> + */
> + hash_tbl->hash_seed = (uint32_t)rte_rand();
> +
No, the current rte_rand() is poor choice for anything hackers would want to know.
Need to use getentropy here. There is a patch series to make rte_rand() better but
if you are trying to prevent DoS then need to use something stronger.
prev parent reply other threads:[~2026-10-05 21:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 20:25 [PATCH] net/bnxt: fix hash seeding and hot-upgrade lock handling Manish Kurup
2026-10-05 21:05 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261005140506.325710d7@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=kishore.padmanabha@broadcom.com \
--cc=manish.kurup@broadcom.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.