Re: [PATCH v2 7/9] gpio: mxc: use local dev variable

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] gpio: mxc: implicit inclusion of linux/of.h
--

commit 28b12eaf4d41de364ce05354d1c3c8a369023e5d
Author: Peng Fan <peng.fan@nxp.com>

gpio: mxc: use local dev variable

This commit introduces a local dev variable to replace repeated &pdev->dev
dereferences in mxc_gpio_probe() to improve readability. It also switches
to the device-model device_is_compatible() API while retaining the np
variable for of_alias_get_id().

> diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
> index c92331f192f91..d762d03c8d6a3 100644
> --- a/drivers/gpio/gpio-mxc.c
> +++ b/drivers/gpio/gpio-mxc.c
> @@ -24,7 +24,7 @@
>  #include <linux/syscore_ops.h>
>  #include <linux/gpio/driver.h>
>  #include <linux/gpio/generic.h>
> -#include <linux/of.h>
> +#include <linux/property.h>
>  #include <linux/bug.h>

[Severity: Low]
Does removing the linux/of.h inclusion violate the 'include what you use'
(IWYU) principle?

Looking at mxc_gpio_probe(), the code still explicitly relies on
of_alias_get_id() when CONFIG_GPIO_SYSFS is enabled:

        if (IS_ENABLED(CONFIG_GPIO_SYSFS))
                port->gen_gc.gc.base = of_alias_get_id(np, "gpio") * 32;

While this compiles today because linux/of.h happens to be implicitly
included through other headers, could removing the explicit include cause
future build breakages if those internal include chains change?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261005-gpio-mxc-cleanup-v2-0-bdc3afbb35e2@nxp.com?part=7