From: Jisheng Zhang <jszhang@kernel.org>
To: Mark Brown <broonie@kernel.org>, Joseph Steel <recv.jo@gmail.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Changhuang Liang <changhuang.liang@starfivetech.com>
Subject: [PATCH v5 3/4] spi: dw: restore previous irq handling behavior when !ctlr->cur_msg
Date: Mon, 5 Oct 2026 23:17:38 +0800 [thread overview]
Message-ID: <20261005151739.25233-4-jszhang@kernel.org> (raw)
In-Reply-To: <20261005151739.25233-1-jszhang@kernel.org>
Recent "enhanced" support changes the dw_spi_irq() behavior a bit
when !!ctlr->cur_msg:
if (!ctlr->cur_msg && dws->transfer_handler == dw_spi_transfer_handler) {
dw_spi_mask_intr(dws, 0xff);
return IRQ_HANDLED;
}
But it misses the dma case, where the transfer_handler ==
dw_spi_dma_transfer_handler, so this changes the previous long time
working behavior, let's restore the previous handling by only filtering
out the dw_spi_enh_handler.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com>
---
drivers/spi/spi-dw-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c
index f82a632ca71c..06f4b0ea954e 100644
--- a/drivers/spi/spi-dw-core.c
+++ b/drivers/spi/spi-dw-core.c
@@ -280,7 +280,7 @@ static irqreturn_t dw_spi_irq(int irq, void *dev_id)
if (!irq_status)
return IRQ_NONE;
- if (!ctlr->cur_msg && dws->transfer_handler == dw_spi_transfer_handler) {
+ if (!ctlr->cur_msg && dws->transfer_handler != dw_spi_enh_handler) {
dw_spi_mask_intr(dws, 0xff);
return IRQ_HANDLED;
}
--
2.53.0
next prev parent reply other threads:[~2026-10-05 15:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 15:17 [PATCH v5 0/4] spi: dw: use threaded interrupt Jisheng Zhang
2026-10-05 15:17 ` [PATCH v5 1/4] spi: dw: remove useless dws->transfer_handler check Jisheng Zhang
2026-10-05 15:17 ` [PATCH v5 2/4] spi: dw: remove duplicated "!rx_len && !tx_len" handling from dw_spi_irq Jisheng Zhang
2026-10-05 15:17 ` Jisheng Zhang [this message]
2026-10-05 15:17 ` [PATCH v5 4/4] spi: dw: use threaded interrupt and optimize the threaded ISR Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261005151739.25233-4-jszhang@kernel.org \
--to=jszhang@kernel.org \
--cc=broonie@kernel.org \
--cc=changhuang.liang@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=recv.jo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.