From: sashiko-bot@kernel.org
To: "Viken Dadhaniya" <viken.dadhaniya@oss.qualcomm.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: i2c: Add Qualcomm I2C target controller
Date: Mon, 05 Oct 2026 16:56:18 +0000 [thread overview]
Message-ID: <20261005165619.1D9B01F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261005-i2c-qcom-slave-v5-1-6254cc7c08d3@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: i2c: missing i2c-controller.yaml ref blocks child nodes
--
commit 2517ccf310dd7ed641c5e449dcf2f13f3b127674
Author: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>
dt-bindings: i2c: Add Qualcomm I2C target controller
This commit documents the device tree bindings for the dedicated I2C
target controller hardware found on Qualcomm QDU1000 and related SoCs.
> diff --git a/Documentation/devicetree/bindings/i2c/qcom,qdu1000-i2c-target.yaml b/Documentation/devicetree/bindings/i2c/qcom,qdu1000-i2c-target.yaml
> new file mode 100644
> index 0000000000000..9a6b08f0ab0e7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/qcom,qdu1000-i2c-target.yaml
[ ... ]
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - interconnects
> +
> +additionalProperties: false
[Severity: Low]
Does using additionalProperties: false in
Documentation/devicetree/bindings/i2c/qcom,qdu1000-i2c-target.yaml without
inheriting from /schemas/i2c/i2c-controller.yaml# strictly reject standard
I2C bus properties and forbid child nodes?
If a developer defines a static I2C target backend (such as slave-eeprom) as a
child node of this controller in a device tree, it appears this regression
would cause a dt_binding_check validation failure.
> +
> +examples:
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261005-i2c-qcom-slave-v5-0-6254cc7c08d3@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-10-05 16:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 16:45 [PATCH v5 0/2] Add Qualcomm I2C target controller driver Viken Dadhaniya
2026-10-05 16:45 ` [PATCH v5 1/2] dt-bindings: i2c: Add Qualcomm I2C target controller Viken Dadhaniya
2026-10-05 16:56 ` sashiko-bot [this message]
2026-10-05 16:45 ` [PATCH v5 2/2] i2c: qcom-target: Add driver for " Viken Dadhaniya
2026-10-05 16:58 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261005165619.1D9B01F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=viken.dadhaniya@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.