From: sashiko-bot@kernel.org
To: "Alireza Haghdoost" <haghdoost@uber.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v5 5/5] perf test: Test lazy symbol loading
Date: Mon, 05 Oct 2026 17:41:52 +0000 [thread overview]
Message-ID: <20261005174153.242931F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261005-perf-symbol-memory-send-v5-5-165dceb2b049@uber.com>
> From: Alireza Haghdoost <haghdoost@uber.com>
>
> Add a perf script shell test for --lazy-load-symbols.
>
> Record a small callchain fixture, require evidence that the controlled
> perf DSO built an on-demand index, and compare only extracted occurrences
> of the controlled test_loop symbol. This avoids coupling the test to
> addresses, diagnostics, or architecture-specific symbols for which the
> eager and lazy loaders have documented differences. When run as root,
> also profile perf in a private mount namespace whose build-id cache
> directory is hidden by a tmpfs, so that names must be read from the
> build-id cache in perf's own namespace.
>
> Report unsupported recording, missing controlled output, and unavailable
> libelf as skips without replacing a prior failure, and keep helper
> [ ... ]
> - on x86_64, a binary with an IRELATIVE PLT slot whose IFUNC loses
> duplicate selection to an alias that loses to another one in turn,
> so the PLT symbol name depends on how the IFUNC mark is passed on.
>
> Signed-off-by: Alireza Haghdoost <haghdoost@uber.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261005-perf-symbol-memory-send-v5-0-165dceb2b049@uber.com?part=5
prev parent reply other threads:[~2026-10-05 17:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 17:30 [PATCH v5 0/5] perf script: Lazy symbol loading Alireza Haghdoost
2026-10-05 17:30 ` Alireza Haghdoost via B4 Relay
2026-10-05 17:30 ` [PATCH v5 1/5] perf symbols: Fix broken ELF_C_READ_MMAP fallback guard Alireza Haghdoost
2026-10-05 17:30 ` Alireza Haghdoost via B4 Relay
2026-10-05 17:37 ` sashiko-bot
2026-10-05 17:30 ` [PATCH v5 2/5] perf dso: Allow reading DSO data from an explicit file Alireza Haghdoost
2026-10-05 17:30 ` Alireza Haghdoost via B4 Relay
2026-10-05 17:41 ` sashiko-bot
2026-10-07 22:09 ` Namhyung Kim
2026-10-05 17:30 ` [PATCH v5 3/5] perf symbols: Factor out duplicate symbol selection Alireza Haghdoost
2026-10-05 17:30 ` Alireza Haghdoost via B4 Relay
2026-10-05 17:37 ` sashiko-bot
2026-10-05 17:30 ` [PATCH v5 4/5] perf script: Add --lazy-load-symbols for lazy symbol loading Alireza Haghdoost
2026-10-05 17:30 ` Alireza Haghdoost via B4 Relay
2026-10-05 17:44 ` sashiko-bot
2026-10-07 22:15 ` Namhyung Kim
2026-10-05 17:30 ` [PATCH v5 5/5] perf test: Test " Alireza Haghdoost
2026-10-05 17:30 ` Alireza Haghdoost via B4 Relay
2026-10-05 17:41 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261005174153.242931F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=haghdoost@uber.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.