From: sashiko-bot@kernel.org
To: "Rosen Penev" <rosenp@gmail.com>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH] leds: is31fl32xx: Fix NULL pointer dereference when binding via I2C ID table
Date: Mon, 05 Oct 2026 19:56:19 +0000 [thread overview]
Message-ID: <20261005195620.1EDA81F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261005194923.161411-1-rosenp@gmail.com>
> If the device binds via the I2C ID table (e.g., fallback matching by
> node name, sysfs new_device, or software node),
> device_get_match_data() in is31fl32xx_probe() returns NULL because
> the is31fl32xx_id table entries have no .driver_data.
>
> Without a NULL check, is31fl32xx_parse_dt() will unconditionally
> dereference cdef when checking cdef->output_frequency_setting_reg,
> and is31fl32xx_parse_child_dt() will dereference cdef->channels,
> leading to a NULL pointer dereference and kernel oops.
>
> Add a NULL check for cdef alongside the existing child count check in
> is31fl32xx_probe(), returning -EINVAL if no match data is available.
>
> Fixes: 2779f4724b2f ("leds: various: use device_get_match_data")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261005194923.161411-1-rosenp@gmail.com?part=1
next prev parent reply other threads:[~2026-10-05 19:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 19:49 [PATCH] leds: is31fl32xx: Fix NULL pointer dereference when binding via I2C ID table Rosen Penev
2026-10-05 19:56 ` sashiko-bot [this message]
2026-10-08 7:49 ` Griffin Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261005195620.1EDA81F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rosenp@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.