Re: [PATCH 1/2] target/arm: Clear TTBR[5:0] from a 52-bit table base address

[Fuad Tabba <fuad.tabba@linux.dev>]

Hi Gustavo,

On Mon, 05 Oct 2026 21:06:44 +0100, Gustavo Romero <gromero@redhat.com> wrote:

[...]

> > diff --git a/tests/tcg/aarch64/system/ttbr-baddr.c b/tests/tcg/aarch64/system/ttbr-baddr.c

[...]

> > +int main(void)

[...]

> > +    /* PARange 52 bits, TGran16 with 52-bit addresses (FEAT_LPA2) */
> > +    if ((mmfr0 & 0xf) != 6 || ((mmfr0 >> 20) & 0xf) != 2) {
>
> I understand you are checking PARange == 6 here for checking if FEAT_LPA (not
> FEAT_LPA2) is also available? If so, maybe change the comment to:
>
> /* PARange 52 bits (FEAT_LPA) and TGran16 with 52-bit addresses (FEAT_LPA2) */
>
> ?

Yes, the test's 52-bit PA and IPA both require FEAT_LPA. I'll take
your comment for v2.

> > +        ml_printf("SKIP: no 52-bit PA or no FEAT_LPA2 with 16KB\n");
> > +        return 0;
>
> Return 'ret' here for consistence?

Sure, I'll change it in v2.

> That's a nice test.
>
> I'm wondering if the fixes should be separated from the tests as we usually do,
> but feel free to wait for collecting more input from the other reviewers about
> it.

Thanks! I kept each test case with the fix it covers, so each patch
carries a test case that fails without its fix. Both forms have gone
into target/arm, including my last contribution. Happy to split if you
prefer. I'll wait for more comments before doing that.

Cheers,
/fuad