Re: [PATCH v10 1/2] arm64: dts: rockchip: rk3568: add XPCS and fixed-clock nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] dt-bindings: rk3568-xpcs compatible and sub-nodes break driver probe
--

commit 14866edde455974144845fb966151f552d75c4c8
Author: Coia Prant <coiaprant@gmail.com>

arm64: dts: rockchip: rk3568: add XPCS and fixed-clock nodes

The RK3568 SoC integrates a Synopsys DesignWare XPCS that provides
the Physical Coding Sublayer for 1000BASE-X, SGMII, and QSGMII
interfaces via its four MII ports. Add the XPCS device node and
its pcs-mii sub-nodes to the SoC device tree.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> index 3bc653f027f1f..2cea108b31a4e 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
[ ... ]
> @@ -110,6 +124,37 @@ sata0: sata@fc000000 {
>  		status = "disabled";
>  	};
>  
> +	xpcs: ethernet-pcs@fda00000 {
> +		compatible = "rockchip,rk3568-xpcs";

[Severity: High]
Will this compatible string prevent the platform driver from binding?

The rockchip,rk3568-xpcs compatible string lacks a generic fallback to
snps,dw-xpcs. Without it, the platform driver (pcs-xpcs-plat.c) will not bind,
causing the stmmac MAC driver to fail to probe (stuck in -EPROBE_DEFER)
since it cannot resolve the pcs-handle.

> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		reg = <0x0 0xfda00000 0x0 0x200000>;
> +		clocks = <&cru PCLK_XPCS>, <&cru CLK_XPCS_EEE>;
> +		clock-names = "csr", "eee";

[Severity: High]
Is the eee clock undocumented in the binding schema?

Including the undocumented eee clock will cause dt_binding_check validation
failures against the snps,dw-xpcs.yaml schema constraints.

> +		power-domains = <&power RK3568_PD_PIPE>;
> +		status = "disabled";
> +
> +		xpcs_mii0: ethernet-pcs-mii@0 {
> +			reg = <0>;
> +			status = "disabled";
> +		};

[Severity: High]
Will this sub-node topology break xpcs_create_fwnode() resolution?

The upstream driver registers its single MDIO device using the parent node's
fwnode. If pcs-handle references this sub-node, fwnode_mdio_find_device()
will return NULL, preventing the MAC driver from resolving the pcs-handle.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261005224008.1140250-1-coiaprant@gmail.com?part=1