From: sashiko-bot@kernel.org
To: "Marcus Flyckt" <marcus.flyckt@kvaser.com>
Cc: lee@kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v2] leds: trigger: netdev: Support devices in other network namespaces
Date: Tue, 06 Oct 2026 07:03:16 +0000 [thread overview]
Message-ID: <20261006070317.07F621F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261006064603.1081262-1-marcus.flyckt@kvaser.com>
> The netdev LED trigger currently cannot resolve a network device that
> has been moved into another network namespace.
>
> For example:
>
> ip link add vm1 type veth peer vm2
> tools/leds/uledmon test:green:netdev &
>
> echo netdev > /sys/class/leds/test:green:netdev/trigger
> echo 1 > /sys/class/leds/test:green:netdev/link
>
> ip netns add ledns
> ip link set vm2 netns ledns
> ip netns exec ledns \
> sh -c 'echo vm2 > /sys/class/leds/test:green:netdev/device_name'
> [ ... ]
> global LED sysfs interface, which is not network namespace aware. The
> namespace is therefore effectively selected by the task that last wrote
> device_name.
>
> Signed-off-by: Marcus Flyckt <marcus.flyckt@kvaser.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261006064603.1081262-1-marcus.flyckt@kvaser.com?part=1
prev parent reply other threads:[~2026-10-06 7:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 6:46 [PATCH v2] leds: trigger: netdev: Support devices in other network namespaces Marcus Flyckt
2026-10-06 7:03 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261006070317.07F621F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marcus.flyckt@kvaser.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.